reverse(A, dims=...) doesn't work for Diagonal, Tridiagonal, etcetera about julia HOT 5 OPEN

Hello, Is anyone currently working on this, if not I'd love to help out. Thanks

from julia.

Just go ahead!

from julia.

Since reverse calls Base._reverse(A, dims), you can overload the latter to dispatch on dims being an integer, e.g.

Base._reverse(A::Diagonal, dims::Integer) = reverse!(Matrix(A); dims)

Should be an easy PR — just add a few of these methods and a test that reverse(A, dims=x) == reverse(Matrix(A), dims=x).

You could also add specialized reverse methods for dims=: (i.e., reversing both dimensions) while you are at it, e.g.

Base._reverse!(A::Diagonal, dims::Colon) = (reverse!(A.diag); A)

(Note that this is the lower-level in-place variant, called by reverse.)

from julia.

hello, I was struggling a bit with solving this issue. If someone could tell me exactly where(ie in which files) I need to overload the method, that would help a lot, thanks!

from julia.

Please submit the fixes to the main Julia repo, where you would need to add the methods to "stdlib/LinearAlgebra/src/diagonal.jl" etc. I would recommend extending reverse directly instead of the internal _reverse, as the latter isn't public.

from julia.