Comments (5)
oscardssmith
commented on July 4, 2024
Do we have a MWE for the regression?
from julia.
vtjnash
commented on July 4, 2024
Yes, sorry, I should have pointed out that this is reported by BaseBenchmarks for this commit: https://github.com/JuliaCI/NanosoldierReports/blob/master/benchmark/by_hash/1c25d93_vs_c0a93f8/report.md
from julia.
Zentrik
commented on July 4, 2024
FWIW, it seems like a lot of the regression has been fixed, but there's still a fairly large regression in the abstract interpretation benchmarks (in the daily benchmarks at least):
Summary
| Range | Mean | Count | |
|---|---|---|---|
| Regressions | 1.97%, 855.32% | 119.18% | 12 |
| Improvements | - | 0.00% | 0 |
| All | 1.97%, 855.32% | 119.18% | 12 |
Abstract Interpretation Benchmarks
| Benchmark | % Change |
|---|---|
| inference.abstract interpretation.Base.init_stdio(::Ptr{Cvoid}) | 855.32% |
| inference.abstract interpretation.REPL.REPLCompletions.completions | 226.32% |
| inference.abstract interpretation.broadcasting | 103.55% |
| inference.abstract interpretation.println(::QuoteNode) | 65.12% |
| inference.abstract interpretation.rand(Float64) | 49.64% |
| inference.abstract interpretation.sin(42) | 45.25% |
| inference.abstract interpretation.many_invoke_calls | 31.07% |
| inference.abstract interpretation.many_method_matches | 21.72% |
| inference.abstract interpretation.many_global_refs | 20.46% |
| inference.abstract interpretation.many_opaque_closures | 7.69% |
| inference.abstract interpretation.many_const_calls | 2.08% |
| inference.abstract interpretation.many_local_vars | 1.97% |
from julia.
Zentrik
commented on July 4, 2024
I bisected a 6x regression in the min run time of BaseBenchmarks.SUITE[["inference", "allinference", "Base.init_stdio(::Ptr{Cvoid})"]] to ea1a0d2, i.e. #53326.
I bisected a 5x regression in the min run time of BaseBenchmarks.SUITE[["inference", "abstract interpretation", "broadcasting"]] to 144f58b, i.e. #53580
from julia.
vtjnash
commented on July 4, 2024
Okay, the init_stdio regression is probably fine then, since we just significantly increased the amount of code visible to the compiler, but didn't change the compiler.
from julia.
Related Issues (20)
- Test failure in `Sockets` with `IOError: listen: address already in use (EADDRINUSE)`
- Overrides.toml broken on master
- `GlobalRef`s as `Dict` keys in precompilation are invalid HOT 1
- `Array{T}(::T)` should return a zero-dimensional array HOT 7
- GC is too lazy, sometimes HOT 10
- External Pkg always recompiles upon loading HOT 12
- REPLExt for Pkg no longer loads when loading a custom Pkg HOT 2
- length() no longer works with Iterators.Stateful in Julia 1.11rc1 HOT 2
- uninitialized typed global can only be imported qualified and not directly HOT 4
- REPL tab completion for paths inside double quotes adds an extra double quote when expanding to a single match
- keymap error when pressing up arrow in REPL HOT 1
- [1.10] Possible thread safety issue in manipulation of doubly linked list of bigval_t? HOT 5
- 'make test' fails for julia-1.11.0-rc1 HOT 1
- Drop OBJPROFILE? HOT 3
- Typing Memory.body() crashes Julia. HOT 1
- Feature request: Finer-grained sleep function HOT 30
- FEATURE REQUEST: Julia REPL to show currently active environment in julia and shell mode HOT 1
- Distributed error with function kwargs HOT 1
- Produce coverage files that include info on non compiled functions
- `USE_BINARYBUILDER_LLVM=0` doesn't work on windows HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from julia.