Giter VIP home page Giter VIP logo

Comments (7)

exaexa avatar exaexa commented on July 24, 2024 1

(note: I forgot to remove the greet() function but it looks labeled with a - instead of the expectable 0, as it is untested code. Is that right?)

adding the report from 1.9.3 just for completeness:

        - module covtest
        - 
        - greet() = print("Hello World!")
        - 
        1 function testfun(n)
        1     [ begin
       10         x = i
       10         x = x * x
       10         x = x + x
       10         x = x / x
       10         x
        -     end for i=1:n]
        - end
        - 
        1 function testfun2(n)
        1     a = n
        1     a *= n
        1     a += n
        1     a /= n
        1     a
        - end
        - 
        - end # module covtest

...anyway so the greet() not being reported at all is probably not a regression but I still wouldn't say it's optimal.

from julia.

sjkelly avatar sjkelly commented on July 24, 2024 1

Likely related to: #53354
which was introduced between 1.10.1 and 1.10.2
cc @JeffBezanson

from julia.

LilithHafner avatar LilithHafner commented on July 24, 2024 1

I just hit this today.

from julia.

exaexa avatar exaexa commented on July 24, 2024

(note: I forgot to remove the greet() function but it looks labeled with a - instead of the expectable 0, as it is untested code. Is that right?)

from julia.

KristofferC avatar KristofferC commented on July 24, 2024

What was the latest version where this worke? 1.10.1, 1.9?

from julia.

exaexa avatar exaexa commented on July 24, 2024

Looks like all was OK on 1.9.3 and 1.9.4 (e.g. here on master: https://github.com/COBREXA/JSONFBCModels.jl/actions/runs/7223225523/job/19681839328 ). In this specific case I found on this merge request: COBREXA/JSONFBCModels.jl#8 and this pipeline: https://github.com/COBREXA/JSONFBCModels.jl/actions/runs/7875684795/job/22202840125 which is 1.10.2.

I can try to bisect later, but I didn't have time to do much stuff lately so please don't count on me there 😅

from julia.

exaexa avatar exaexa commented on July 24, 2024

In other news, I'm getting several similar cases with functions that are easy to inline, such as:

Base.:+(a::Int, b::Whatevs) = b+a
Base.:+(a::Whatevs, b::Int)= combine_whatevs_with_int(a,b)

The first line never gets coverage; even calls to 0 + Whatevs() generate coverage ticks for the second line.

I somehow assume there's an over-zealous optimization somewhere in the way.

from julia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.