Giter VIP home page Giter VIP logo

Comments (5)

oscardssmith avatar oscardssmith commented on August 28, 2024

given that the regression was a bugfix, it seems unlikely to be fixable

from julia.

KristofferC avatar KristofferC commented on August 28, 2024

I wouldn't say that. Bugfixes introduce perf regressions all the time but they can often be tweaked to keep the bug fixed while fixing the perf regression.

from julia.

KristofferC avatar KristofferC commented on August 28, 2024

cc @N5N3

from julia.

N5N3 avatar N5N3 commented on August 28, 2024

It seems impossible that the doubled allocation all comes from UnionAll unaliasing.
So there might be some unexpected side effect.
I will take a look when I have time, but not sure if there's a (quick) fix.

from julia.

N5N3 avatar N5N3 commented on August 28, 2024

Tried to test this a bit locally, It turns out that 02f27c2 caused this "regression".
I have verified that type intersection does generate some result with free TypeVar on v1.10.2 during Makie's pre-compilation.
IIUC, this would change the result of inference and "simplified" the compiled signature, thus make loading faster.
From this perspective, this is not a regression of type intersection itself.

BTW, I also noticed that the inputs of jl_type_intersection_env_s might contain free TypeVar even during bootstrap.
And obviously, these free TypeVars do not come from type intersection. @vtjnash Is this expected?

from julia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.