Giter VIP home page Giter VIP logo

Comments (19)

tkelman avatar tkelman commented on May 18, 2024

were there any API changes? if the bundled binaries pass the validation tests, this should happen automatically

from mbedtls.jl.

wildart avatar wildart commented on May 18, 2024

No, it's the same version 2.2.1. I guess BinDeps would detect julia provided libs and setup package against them.

from mbedtls.jl.

tkelman avatar tkelman commented on May 18, 2024

The package is using 2.1.1 at the moment - https://github.com/JuliaWeb/MbedTLS.jl/blob/master/deps/build.jl

I'm pretty sure that's insecure and needs to be updated for the sake of 0.4 though.

from mbedtls.jl.

wildart avatar wildart commented on May 18, 2024

I misread it. Sure update is required. Hopefully, it would be easy with julia shipped binaries.

from mbedtls.jl.

tkelman avatar tkelman commented on May 18, 2024

The validation here should be a lot stricter if there are potential API changes and binaries coming from Julia as well as previously-built (or downloaded) binaries of older versions around. Why didn't your libgit2 work use 2.3.0?

from mbedtls.jl.

wildart avatar wildart commented on May 18, 2024

When I wrote patch to libssh2 when 2.2.1 was the last version. As I understand 2.1.5 is a maintenance release now. And it looks like we would require to use it or 2.3.* because of fixes to bignum API.

I prefer 2.3.* as it has better custom configuration build support.

from mbedtls.jl.

tkelman avatar tkelman commented on May 18, 2024

are there api changes between 2.2 and 2.3, does your patch for libssh2 need changing at all, or should it be a simple version bump and replacing the checksums? if it's the latter I can add it to JuliaLang/julia#17475

from mbedtls.jl.

wildart avatar wildart commented on May 18, 2024

version bump should work

from mbedtls.jl.

malmaud avatar malmaud commented on May 18, 2024

Are there any action items for me?

from mbedtls.jl.

tkelman avatar tkelman commented on May 18, 2024

it isn't doing this correctly yet, so yes - get it working

from mbedtls.jl.

malmaud avatar malmaud commented on May 18, 2024

Have we figured out why bindeps isn't automatically finding the bundled binaries? Maybe I'll just add custom logic to build.jl.

from mbedtls.jl.

tkelman avatar tkelman commented on May 18, 2024

Are your bindings up to date with the 2.3 API? Does 2.3 pass your validation checks?

from mbedtls.jl.

malmaud avatar malmaud commented on May 18, 2024

Looking at https://github.com/ARMmbed/mbedtls/blob/development/ChangeLog, there were no API changes between 2.1 and 2.3, so it should be as simple as making sure bindeps picks up the binary.

from mbedtls.jl.

malmaud avatar malmaud commented on May 18, 2024

Hmm, so as far as I can tell, the library in julia/usr/lib passes the validation test. Are we sure that path is checked by BinDeps?

from mbedtls.jl.

tkelman avatar tkelman commented on May 18, 2024

Maybe not. Try a provides(Binaries or something? be sure you use the relative paths for a binary install of julia, not a source install.

from mbedtls.jl.

malmaud avatar malmaud commented on May 18, 2024

I can't actually find where they are in the binary install of Julia, at least on OS X. At least they are not in Julia-0.6.app/Contents/Resources/julia/lib.

from mbedtls.jl.

malmaud avatar malmaud commented on May 18, 2024

Oh, NM.

from mbedtls.jl.

malmaud avatar malmaud commented on May 18, 2024

Alright, #66 is my attempt at closing this.

from mbedtls.jl.

quinnj avatar quinnj commented on May 18, 2024

Implemented in #81

from mbedtls.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.