Comments (7)
juliangruber
commented on June 9, 2024
i used to use browser-launcher2 but switched back to browser-launcher because that was working better for most cases. i'm happy to merge something in if it works well, but currently don't have time to work on this on my own.
out of curiosity, what windows version are you running?
from browser-run.
sprat
commented on June 9, 2024
I use Vista. I would upgrade if I could, but the update is so expensive...
But anyway, if you look at the windows browser detection code, it's really fragile. Do you remember the issue you had with browser-launcher2?
from browser-run.
juliangruber
commented on June 9, 2024
i just looked through the history and it seems like this never actually used browser-launcher2. i'd be happy to accept a pull request to move to that.
from browser-run.
sprat
commented on June 9, 2024
I'm trying to do that but I am annoyed because I can't even run the tests. First, there is the makefile: I've replaced it by regular npm scripts. Then, many tests fail: all the tests using electron fail on my machine, that's not really surprising, but also phantomjs, spawn, and stream ones! Don't know if I'll have time to fix that too. Note that I installed phantomjs globally, so phantomjs tests should probably work...
For the record, here are the errors I get:
test/close.js ......................................... 0/2 3s
window.close()
not ok exit
+++ found
--- wanted
-0
+3221225785
compare: ===
at:
line: 13
column: 7
file: test/close.js
type: Stream
source: |
t.equal(code, 0, 'exit');
stack: |
Stream.<anonymous> (test/close.js:13:7)
Electron.<anonymous> (index.js:98:15)
Electron._exit (node_modules/electron-stream/index.js:96:8)
window.close()
not ok test unfinished: window.close()
at:
line: 4
column: 1
file: test/close.js
plan: 2
count: 1
source: |
test('window.close()', function (t) {
test/empty.js ......................................... 1/1 738ms
test/error.js ......................................... 1/1 983ms
test/phantom.js ....................................... 0/3 30s
phantomjs
not ok Error: spawn phantomjs ENOENT
at:
line: 856
column: 11
file: util.js
function: exports._errnoException
code: ENOENT
errno: ENOENT
syscall: spawn phantomjs
path: phantomjs
spawnargs:
- "C:\\Users\\Sylvain\\AppData\\Local\\Temp\\phantomjs-stream:1bc1bf06"
test: phantomjs
message: 'Error: spawn phantomjs ENOENT'
stack: |
exports._errnoException (util.js:856:11)
phantomjs
not ok missing test
not ok missing plan
results:
ok: false
count: 1
pass: 0
fail: 1
failures:
- ok: false
id: 1
time: 68.458
name: phantomjs
diag:
at:
line: 5
column: 1
file: test/phantom.js
results:
plan:
start: 1
end: 2
count: 2
pass: 0
ok: false
fail: 2
time: 68.458
source: |
test('phantomjs', function (t) {
test/spawn.js ......................................... 0/1 569ms
spawn
not ok Error: spawn UNKNOWN
at:
line: 856
column: 11
file: util.js
function: exports._errnoException
code: UNKNOWN
errno: UNKNOWN
syscall: spawn
test: spawn
message: 'Error: spawn UNKNOWN'
stack: |
exports._errnoException (util.js:856:11)
exports.spawn (child_process.js:362:9)
test/spawn.js:5:12
Test.test (node_modules/tap/lib/test.js:445:17)
Object.<anonymous> (test/spawn.js:4:1)
test/stream.js ........................................ 0/1 1s
stream
not ok test unfinished: stream
at:
line: 4
column: 1
file: test/stream.js
source: |
test('stream', function (t) {
total ................................................. 2/9
2 passing (37s)
7 failing
from browser-run.
juliangruber
commented on June 9, 2024
You could set up a Linux Vm for running this project, so you have a good starting point.
This error spawn phantomjs ENOENT shows that maybe on Windows we should spawn phantom.exe or something.
from browser-run.
sprat
commented on June 9, 2024
First thing you should probably do in every dependent library: use cross-spawn instead of child_process.spawn. See nodejs/node-v0.x-archive#5841
from browser-run.
rtsao
commented on June 9, 2024
This might fix at least the phantom test issue for you: #79
from browser-run.
Related Issues (20)
- `browser-launcher` is no longer maintained HOT 32
- Issues to many xhr HOT 15
- Hangs in FF. running window.close() won't finish process HOT 11
- Cannot run unpublished version HOT 3
- [OS X] Window focus doesn't go back to the terminal after switching to Electron
- Doesn't work with Chrome on MacOS HOT 1
- An in-range update of electron-stream is breaking the build 🚨 HOT 2
- Works in everything EXCEPT Electron HOT 11
- An in-range update of source-map-support is breaking the build 🚨 HOT 1
- going form 3.5.0 to 3.6.0 breaks http CORS requests and --mock HOT 3
- doesn't work with js code that contains a </script> HOT 3
- Node postinstall script fails HOT 1
- Publish 4.1.1 to npm registry HOT 2
- node_modules\browser-run\index.js:4:22 Cannot resolve dependency HOT 3
- Firefox: Unhandled stream error in pipe. HOT 6
- Usage on GitHub Actions with xvfb HOT 11
- Browsers other than electron don't close HOT 2
- No output HOT 8
- Support import in scripts HOT 2
- output stream error HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from browser-run.