Comments (11)
That is a good catch! I wonder if I should cache the instance forever, or put it in a WeakReference
and use it while it is available.
from gson-fire.
It's coming out tomorrow
from gson-fire.
Thanks for the fix!
When will you release the next version?
from gson-fire.
Mid oct at the latest
Just for curiosity, was this causing performance issues for you? I assume it was the reflection invocation of newInstance
in the class
from gson-fire.
Yes, gson already creates many classes. With fire and all my stuff enabled it got up to millions of instances, Many of those were the exclusion strategies - something I couldn't really fix.
Is there a snapshot i can use to test if it's fixed?
from gson-fire.
No snapshot, but you can clone this repo, checkout branch v1.8.0_exclude-by-value-singleton
, change the pom version to whatever you want, do mvn install
and then use that version in your code. Maven should resolve the dependency locally
from gson-fire.
Still waiting on that 1.7.3 release 🌴
from gson-fire.
julman99 commented 4 days ago
It's coming out tomorrow
😢
from gson-fire.
I am terribly sorry for the delay. Just released version 1.8.0 and it contains the fix for this issue. Can you confirm you see an improvement?
from gson-fire.
Hi I think it's fixed but I can't test it right now because my profiler license expired.
from gson-fire.
Thanks again. I forgot to close.
from gson-fire.
Related Issues (20)
- Add more powerful wrapping/unwrapping HOT 1
- Reuse Objects HOT 2
- Hooks Exception is not forwarded. HOT 2
- TypeAdapter does not respect `lenient` value HOT 3
- Custom deserialization without deserializer/type adapter? HOT 3
- Custom Deserialization of same field based on it's type
- Preprocessor for Array Insertion HOT 6
- Can't serialize NaN HOT 11
- RFC3339 Parser is wrong HOT 2
- Serialize complex map keys to strings and back HOT 2
- Add OSGi Support HOT 10
- Inconsistent licensing information
- Missing Releases on Github HOT 1
- Check for required fields HOT 1
- Unresolved requirement: Import-Package: com.google.gson.internal.bind HOT 2
- No release tags for versions 1.8.4 and 1.8.5?
- How to exclude a field from serialization?
- update gson from 2.8.6 to version com.google.code.gson:gson:2.8.9 HOT 1
- osgi is not more compatible with new version of gson HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gson-fire.