Reuse Exclusion Strategies about gson-fire HOT 11 CLOSED

That is a good catch! I wonder if I should cache the instance forever, or put it in a WeakReference and use it while it is available.

from gson-fire.

It's coming out tomorrow

from gson-fire.

Thanks for the fix!
When will you release the next version?

from gson-fire.

Mid oct at the latest

Just for curiosity, was this causing performance issues for you? I assume it was the reflection invocation of newInstance in the class

from gson-fire.

Yes, gson already creates many classes. With fire and all my stuff enabled it got up to millions of instances, Many of those were the exclusion strategies - something I couldn't really fix.
Is there a snapshot i can use to test if it's fixed?

from gson-fire.

No snapshot, but you can clone this repo, checkout branch v1.8.0_exclude-by-value-singleton, change the pom version to whatever you want, do mvn install and then use that version in your code. Maven should resolve the dependency locally

from gson-fire.

Still waiting on that 1.7.3 release 🌴

from gson-fire.

julman99 commented 4 days ago
It's coming out tomorrow

😢

from gson-fire.

I am terribly sorry for the delay. Just released version 1.8.0 and it contains the fix for this issue. Can you confirm you see an improvement?

from gson-fire.

Hi I think it's fixed but I can't test it right now because my profiler license expired.

from gson-fire.

Thanks again. I forgot to close.

from gson-fire.