jupyter_lsp - different location of jupyter-lsp-notebook.json between 2.2.2 and 2.2.3 about jupyterlab-lsp HOT 3 CLOSED

Yes, in 2.2.3 we partially modernized the setup script/config removing data_files from setup.py:

  setuptools.setup(
-     data_files=[
-         (
-             "etc/jupyter/jupyter_server_config.d",
-             ["jupyter_lsp/etc/jupyter-lsp-jupyter-server.json"],
-         ),
-         (
-             "etc/jupyter/jupyter_notebook_config.d",
-             ["jupyter_lsp/etc/jupyter-lsp-notebook.json"],
-         ),
-     ],
  )

and adding it in setup.cfg (still not pyproject.toml, but some progress):

+ [options.data_files]
+ etc/jupyter/jupyter_server_config.d = jupyter_lsp/etc/jupyter-lsp-jupyter-server.json

Now, you can see that jupyter-lsp-notebook.json is no longer there, only jupyter-lsp-jupyter-server.json. This is because we no longer support the old notebook server and require a modern jupyter-server.

The fact that jupyter_lsp/etc/jupyter-lsp-notebook.json was not deleted appears to be an omission. I think we should simply remove it in the next patch release.

from jupyterlab-lsp.

Oh, I see. I thought that both JSONs are the same but you are right that the jupyter-lsp-jupyter-server.json is still installed in the same location. Thank you for the quick reply.
We can keep this open as a reminder to remove the old JSON.

from jupyterlab-lsp.

jupyter-lsp 2.2.4 should have solved it, please reopen if there is still a problem. Thanks!

from jupyterlab-lsp.