Giter VIP home page Giter VIP logo

Comments (10)

fcollonval avatar fcollonval commented on June 9, 2024 1

@dhirschfeld I'ld love to get my PR merged. But there is a packaging issue due to monaco-languageclient 0.9.0. A alias for a simplified vscode package should be passed to webpack. For building the extension it is easy. But for jupyterlab I don't know how to do it with out touching the standard webpack.config shipped with jupyterlab.
Maybe @gnestor or @jasongrout have some ideas?

from jupyterlab-monaco.

jasongrout avatar jasongrout commented on June 9, 2024

Yes. Do you feel comfortable doing so? Do you want permissions to do so?

from jupyterlab-monaco.

gnestor avatar gnestor commented on June 9, 2024

Sure. I think I might because I have access to the jupyterlab org on npm. Do we want to publish as jupyterlab-monaco or @jupyterlab/monaco, or @jupyterlab/monaco-extension?

from jupyterlab-monaco.

jasongrout avatar jasongrout commented on June 9, 2024

Oh right, I forgot we never published this (I thought you were asking about updating...). It's still, of course, very experimental, but on the other hand, some people have appreciated having it.

Let me take a look at what I think would be a good first cut of features before we initially publish this.

from jupyterlab-monaco.

gnestor avatar gnestor commented on June 9, 2024

I agree that it's a great extension, I've been using it in lieu of the default file editor. I will help with future development, publishing, etc. 👍

from jupyterlab-monaco.

nabriis avatar nabriis commented on June 9, 2024

Is it getting published?

from jupyterlab-monaco.

gnestor avatar gnestor commented on June 9, 2024

I just reviewed the open issues on this repo and it looks like there are some jupyterlab monaco extensions for other jupyterlab-based apps that offer LSP integration and monaco in notebook code cells, so maybe we should wait to add these features before publishing this package? Or we can just publish now that it's stable...

from jupyterlab-monaco.

TiemenSch avatar TiemenSch commented on June 9, 2024

I'd say that it would help to get some traction just by publishing what there already is!

from jupyterlab-monaco.

dhirschfeld avatar dhirschfeld commented on June 9, 2024

Maybe merge #22 (if it's ready to go now) then publish?

from jupyterlab-monaco.

gnestor avatar gnestor commented on June 9, 2024

@fcollonval Excellent work on #22!! I don't fully understand your packaging issue. Can you give me an idea of what webpack config would need to change?

One way around webpack issues in general is to append scripts to the DOM. I have done this in other projects to get monaco editor working when webpack isn't exactly configurable. Not sure if this relevant to you issue...

from jupyterlab-monaco.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.