Giter VIP home page Giter VIP logo

Comments (7)

aprokopenko avatar aprokopenko commented on June 1, 2024

Hi Raju,

Could you clarify your question?

tag requires js file in some IE versions (don't remember exactly the name). It's not included inside the plugin.

Otherwise all should work fine

from just-responsive-images.

therajumandapati avatar therajumandapati commented on June 1, 2024

For ex: https://www.knowledgeservices.com/about-us/

The hero image on this page is defaulting to the mobile resolution. It was <picture> tag before, but I changed it to use <img>.

What do you suggest in this situation in terms of JRI config etc so that the smallest image is not loaded as the backup because it's too small to fit in the container.

Is that JS file you're mentioning an additional code we need to find somewhere and add to site?

from just-responsive-images.

aprokopenko avatar aprokopenko commented on June 1, 2024

https://scottjehl.github.io/picturefill/ - it seems this is the js, which is required in lower IE versions.

I will ask our frontend guru on Monday to be sure.


As I can see the picture tag is generated correctly.

from just-responsive-images.

therajumandapati avatar therajumandapati commented on June 1, 2024

@aprokopenko Can you point me to any Production sites you know are using JRI?

from just-responsive-images.

therajumandapati avatar therajumandapati commented on June 1, 2024

@aprokopenko Thanks for sharing the link to that <picture> polyfill, it works.

On that note, what do you think about adding that dependency in JRI?

from just-responsive-images.

aprokopenko avatar aprokopenko commented on June 1, 2024

Not all sites has support of IE10/11. We support only Edge by default.
Modern web starter kits use require.js and has this dependency inside. So if you need your theme to support picture in IE 10/11 - then you should know the compatibility issues and how to fix them.

from just-responsive-images.

therajumandapati avatar therajumandapati commented on June 1, 2024

Sounds good @aprokopenko, thank you for the insights.

from just-responsive-images.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.