Giter VIP home page Giter VIP logo

Comments (4)

brainmurphy avatar brainmurphy commented on June 12, 2024

👍

Really eager to see this. Everyone that's worked on JustSaying wants this to happen, but the main blocker is the unreliable test suite. If we have changes that can improve that reliability, without decreasing the coverage/confidence that the tests provide, they should definitely be submitted.

from justsaying.

payman81 avatar payman81 commented on June 12, 2024

@dariusdamalakas
DynamoDb tests can go.
Your PR #133 now allows for sns and sqs client to be substituted with a different implementation. We can improve the test suit by using an in-memory implementation of sns and sqs client.

from justsaying.

gerektoolhy avatar gerektoolhy commented on June 12, 2024

@payman81, yes, we can switch to a mocked sns/sqs client implementation. On the other hand, i quite like that integration tests are being run against actual SQS/SNS.

Here is the latest build on appveyor. The set-up is easy:

  1. There's a custom AWS client factory, that inspects environment variables looking up for API key and secret. If it's there, builds a custom AWSCredentials, and uses that to authenticate.
  2. Then in the AppVeyor settings it's just a matter of setting the right API keys.

I can polish a PR for this. and then it's up to you to configure this. (I expect that you would want to own the CI build setup). We can then work slowly to clean-up tests and make them correctly run repeatably.

from justsaying.

brainmurphy avatar brainmurphy commented on June 12, 2024

AppVeyor build: https://ci.appveyor.com/project/justeattech/justsaying There's still an issue about running the integration tests from there; I'll open a separate issue for that.

from justsaying.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.