Thanks for this plugin! I found builds were taking 18 seconds for me

Speeding up generation about amp-jekyll HOT 5 OPEN

pauldambra commented on June 28, 2024

Speeding up generation

from amp-jekyll.

Comments (5)

juusaw commented on June 28, 2024

Sounds good! I'd be happy to test the parallelization and accept the PR.

from amp-jekyll.

pauldambra commented on June 28, 2024

Cool. Might be the weekend before I get to take a proper look...

…

On Tue, 28 Mar 2017, 08:05 Juuso Mikkonen, ***@***.***> wrote: Sounds good! I'd be happy to test the parallelization and accept the PR. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA8G8UDQiPV60bnEduqUukThFPVo8ciFks5rqLEmgaJpZM4Ml9bN> .

from amp-jekyll.

pauldambra commented on June 28, 2024

Just looking at adding this and having to include changes made here since I copied the files for my blog...

One of the changes added a layout:amp to the top of the AMP layout

---
layout: amp
---
<!doctype html>
<html amp lang="en">

but that just causes warnings and doesn't render anything for me...

Build Warning: Layout 'amp' requested in amp/2016/yarn/index.html does not exist.

I think I must be misunderstanding something..?

from amp-jekyll.

juusaw commented on June 28, 2024

Hi, did you update all the changed files before applying your updates? I managed to get the threaded version working from the latest version of master.

class AmpGenerator < Generator
    priority :low
    def generate(site)
      dir = site.config['ampdir'] || 'amp'
      threads = site.posts.docs.map do |post|
        next if post.data['skip_amp'] == true
        Thread.new do
          site.pages << AmpPost.new(site, site.source, File.join(dir, post.id), post)
        end
      end
      ThreadsWait.all_waits(*threads)
    end
  end

from amp-jekyll.

pauldambra commented on June 28, 2024

:) It's worked for me without the skip for many builds now. If it's working for you too then was doing too many things at once this morning... I must have done something silly

from amp-jekyll.

Recommend Projects