Giter VIP home page Giter VIP logo

Comments (2)

georg-schwarz avatar georg-schwarz commented on June 3, 2024 1

Ah I remember, there was a feature planned for it (showing pipelines for a data source). Please keep it!

from ods.

f3l1x98 avatar f3l1x98 commented on June 3, 2024

I have been looking into it and that is definitely a UI issue, but:
The UI REST Api function getPipelineByDatasourceId is only used once for the Vuex action, BUT:
This Vuex action loadPipelineByDatasourceId is never used

ods/ui/src/pipeline/pipeline.module.ts

Lines 75 to 78 in 57e8070

@Action({ commit: 'setSelectedPipeline', rawError: true })
public async loadPipelineByDatasourceId (datasourceId: number): Promise<Pipeline> {
return await RestService.getPipelineByDatasourceId(datasourceId)
}

Additionally the logic of the action is wrong because it depends on the REST call returning only one Pipeline, but from my understanding (I am fairly new to the project) a datasource can have multiple pipeline(-config)s.
Thus my question @georg-schwarz :
Is there any reason to keep this Vuex action, even though it is unused?

from ods.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.