Comments (5)
Current there's a default prop for target: '_blank'
on the link component, which should probably be removed. I briefly looked into this but didn't get it in https://github.com/remarkjs/remark-external-links
from mdx-deck.
Currently the webpack config is set in the CLI here and remark plugins are passed to the custom loader as options: https://github.com/jxnblk/mdx-deck/blob/master/cli.js#L48-L50
from mdx-deck.
Yeah, we could detect via the href
prop whether it starts with a hash or not – the link can be completely customized with the components
object, but I think it's good to have smart defaults built in. But, the simplest solution is probably to remove the default prop for now
from mdx-deck.
Where would the change have to take place? Where does remark come into play?
from mdx-deck.
It would be great to enable user land to define if the link should be external (or maybe external is default) can be set to internal f.e. If we know we're dealing with an internal link than we could also navigate to the selected slide.
from mdx-deck.
Related Issues (20)
- Integrating the presentation into existing website causes number of issues
- gatsby-theme-mdx-deck not working
- Running mdx-deck <filename>.mdx constantly forces a repaint in the browser and the recreation of gatsby pages. HOT 10
- Simple create, resize and fill div
- Presenter mode inaccessible in Windows HOT 3
- Infinite loop when using steps HOT 6
- Readme Clarity
- File-Import in 4.1.1 not working
- Can't start mdx-deck on localhost HOT 1
- Still supported/maintained? HOT 8
- Is there a way to run custom javascript on deck load and slid transitions ? HOT 3
- Can't resolve 'mdx-deck/themes' HOT 2
- Is there support for remark plugins?
- Can this be used with Next.Js HOT 2
- Trying to get in touch with you regarding a security issue
- Import partial slide decks? HOT 4
- Upgrade Gatsby to v3? HOT 2
- "Getting Started" steps do not work HOT 4
- Need custom shortcuts
- Not running on Gatsbyjs 4 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mdx-deck.