Giter VIP home page Giter VIP logo

Comments (5)

jxnblk avatar jxnblk commented on July 16, 2024 1

Current there's a default prop for target: '_blank' on the link component, which should probably be removed. I briefly looked into this but didn't get it in https://github.com/remarkjs/remark-external-links

from mdx-deck.

jxnblk avatar jxnblk commented on July 16, 2024 1

Currently the webpack config is set in the CLI here and remark plugins are passed to the custom loader as options: https://github.com/jxnblk/mdx-deck/blob/master/cli.js#L48-L50

from mdx-deck.

jxnblk avatar jxnblk commented on July 16, 2024 1

Yeah, we could detect via the href prop whether it starts with a hash or not – the link can be completely customized with the components object, but I think it's good to have smart defaults built in. But, the simplest solution is probably to remove the default prop for now

from mdx-deck.

busypeoples avatar busypeoples commented on July 16, 2024

Where would the change have to take place? Where does remark come into play?

from mdx-deck.

busypeoples avatar busypeoples commented on July 16, 2024

It would be great to enable user land to define if the link should be external (or maybe external is default) can be set to internal f.e. If we know we're dealing with an internal link than we could also navigate to the selected slide.

from mdx-deck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.