Giter VIP home page Giter VIP logo

Comments (5)

jzillmann avatar jzillmann commented on July 30, 2024

Ya, thats true i added a rounding since for my benchmarks the decimals were just annoying ;)
Question. Would it make sense in your case to switch to the next lower OutputTimeUnit, like microseconds ?

If not i was thinking about something like when the values are bigger then a certain threshold (lets say 10) then do the rounding otherwise don't.

from jmh-visualizer.

BrainStone avatar BrainStone commented on July 30, 2024

Generally speaking, why round at all? These small differences might be important and people might not have the possibility or the time (a proper benchmark could take days) to redo the benchmark with a different scale.

from jmh-visualizer.

jzillmann avatar jzillmann commented on July 30, 2024

For me the main benefit is of having the visualizer is cutting through the noise and seeing the most important thing as easy as possible by not being distracted by un-important things!
For the scales i worked with so far, decimals were clearly unimportant.
And i understand that the situation is different for you.

Just wanna check if you are aware on changing the unit and if so, what are your reasons!

from jmh-visualizer.

BrainStone avatar BrainStone commented on July 30, 2024

I understand that. But regardless if you want to round I'd recommend rounding to sig figs. Like on the graph 2 sig figs should be sufficient and when hovering over the data 4 are a good choice I think.

To illustrate, here is a small table:

Original value 2 sig figs (labels on the graph) 4 sig figs (when hovering)
123456 120000 123500
123.456 120 123.5
12.3456 12 12.35
1.23456 1.2 1.235
0.123456 0.12 0.1235
0.000123456 0.00012 0.0001235

Or in scientific notation (which really illustrates the way of rounding):

Original value 2 sig figs (labels on the graph) 4 sig figs (when hovering)
1.23456e5 1.2e5 1.235e5
1.23456e2 1.2e2 1.235e2
1.23456e1 1.2e1 1.235e1
1.23456e0 1.2e0 1.235e0
1.23456e-1 1.2e-1 1.235e-1
1.23456e-4 1.2e-4 1.235e-4

There should be methods somewhere in the internet that do that rounding.

from jmh-visualizer.

jzillmann avatar jzillmann commented on July 30, 2024

Along with the 0.5.1 version i disabled rounding for datasets where each score was below a certain threshold. Please give it a try and let me know how you like it!

from jmh-visualizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.