Giter VIP home page Giter VIP logo

Comments (3)

purbon avatar purbon commented on August 25, 2024

Hi @christophschubert thanks a lot for your help here. I love to kick an improved design of the descriptor file, however I think this deserve a bit more thinking.

I want to provide a bit more of answers and context here:

1.- we cannot add additional meta-data fields to the 'header' of a topology YAML, at least not between context and projects.

yes, you can. Between the context and the project tag, the list of elements in the deserialiser is open. This is an example: https://github.com/purbon/kafka-topology-builder/blob/master/example/descriptor-with-schemas.yaml

2.- This goes against the YAML spec (https://yaml.org/spec/1.2/spec.html), see quote below. Which in turn means we have to rely on hand-written parsers.

This makes more sense, I was not aware of this design principle in yaml.

I would say, lets give thought to this, with as much people as possible chimming in, so we cover the most out of it.

I think this is an amazing thing to merge in for the upcoming 2.x branch. I would love to release as soon as possible an stable (as much as possible 1.x branch)

from julie.

christophschubert avatar christophschubert commented on August 25, 2024

1.- we cannot add additional meta-data fields to the 'header' of a topology YAML, at least not between context and projects.

yes, you can. Between the context and the project tag, the list of elements in the deserialiser is open. This is an example: https://github.com/purbon/kafka-topology-builder/blob/master/example/descriptor-with-schemas.yaml

But these become part of the topic-names. I was thinking about user-defined meta-data which should not become part of the topic names.

from julie.

purbon avatar purbon commented on August 25, 2024

Hi @christophschubert, The meta-data part of your enhancement request in this issue has been covered by the solution of #199, leaving mostly open only for this issue the yaml spec compliance

from julie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.