Python syntax-highlighting about material.vim HOT 9 CLOSED

Hey, thanks for the issue. You're correct - there aren't any specific colors set for any Python syntax plugins. I'm mostly a JS dev, which is why there's a lot of customization there.

PRs are welcome! I would just want to make sure we're adding colors for a popular syntax plugin. You can see an example of the JS colors here.

from material.vim.

I see, Vim-polyglot has ~2500 stars on their github repo. Do I start adding highlighting for python uses that syntax plugin?

from material.vim.

It looks like vim-polyglot uses this syntax plugin.

from material.vim.

I have started writing the colors for python now.

from material.vim.

I am quite happy with the syntax highlighting for Python now. @mariush2, you had used a very bare script for comparison. See instead:

import unittest
import os


class TestFile(unittest.TestCase):

    def setUp(self):
        self.file = open("test_file.txt", "w")

    def tearDown(self):
        os.remove("test_file.txt")

    def test_meh(self):
        self.file.write("manga")


if __name__ == "__main__":
    unittest.main()

from material.vim.

To clarify what I want to achieve with the new highlighting for python.

Here is a screenshot of some code in vim:

Here is the same piece of code in Atom using the material theme:

I want to get closer to the Atom look in vim here. Specifically on lines like request.session['login'] = True and user = authenticate(username=form.username, password=form.password)

from material.vim.

Just my opinion, take it as constructive feedback:

• Overall I feel the vim version is easier to read
• 👍 for colouring methods (is_valid) and classes / functions (LoginForm, redirect) in blue and keyword args (commit=, username=) in cyan - it might be possible to do that in vim, and maybe it helps
• 👎 However, I don't like how the color of the variable request, form, user etc change between based on context. It is distracting.

from material.vim.

I'm definitely open to adding some Python-specific syntax highlighting. I'd love to try to keep colors consistent between languages where we can, but that's obviously not possible 100% of the time. If someone does decide to take this on, if we could use the JS example provided by the issue author as a guide, I think we'll be on the right track.

from material.vim.

Closing this due to lack of movement. Comment above still stands and would definitely be open to updating styles. :)

from material.vim.