Giter VIP home page Giter VIP logo

Comments (4)

kaicataldo avatar kaicataldo commented on June 16, 2024

Hey, mind sharing a screenshot of what you're proposing? It'll make it easier to make a decision then. Thanks!

from material.vim.

skbolton avatar skbolton commented on June 16, 2024

So here is how vscode palenight shows the cursor line. Notice the darker background Screen Shot 2019-04-24 at 12 31 01 AM

And here is how the palenight.vim cursor line looks, little lighter than vscode but still dark.
Screen Shot 2019-04-24 at 12 31 31 AM

and here is this repo's cursor line. To me it looks the like the same green as the default color
Screen Shot 2019-04-24 at 12 34 21 AM

I can make edits and post a photo of the changes in this repo. But roughly what I was proposing was to move away from the greenish color and do a darker than the background color.

Love it? Hate it?

from material.vim.

kaicataldo avatar kaicataldo commented on June 16, 2024

That definitely looks like an improvement to me. I'd love to match the official VS Code version where possible :)

One thing to note is that this uses one of the predefined colors. I wonder if the other flavors (default/dark) also use a darker color? If the VS Code theme doesn't use any of the colors already defined in these variable, I think we should add a new variable for this and re-use it across the different themes. Does that make sense?

from material.vim.

kaicataldo avatar kaicataldo commented on June 16, 2024

This should be fixed by #21

from material.vim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.