Add extensions to ticket validator about cas-security-spring-boot-starter HOT 5 OPEN

@igorhara Thank you for reporting. I'm not totally sure to understand completely your needs. So I have some questions:

Are you aware that you're able to customize and add/configure your own implementation of org.jasig.cas.client.validation.TicketValidator which is responsible to validate ticket. By registring a bean that implement org.jasig.cas.client.validation.TicketValidator.

Because CasTicketValidatorConfiguration will only be configured if you're not providing your own TicketValidator bean.

So if somewhere in your configuration you define a new bean of

@Bean
TicketValidator myCustomTicketValidator() {
    return new MyCustomTicketValidator();
}

Where MyCustomTicketValidator is implementing TicketValidator.

Does it not enough for you?

from cas-security-spring-boot-starter.

from cas-security-spring-boot-starter.

@igorhara So why do you not creating a bean extending Cas30ServiceTicketValidator (or whatever the version, depending of your needs) and then overriding protected Map<String, Object> extractCustomAttributes(final String xml) method?

from cas-security-spring-boot-starter.

That is what I am doing, but I had to read the source code in order to be able to configure my custom TIcketValidator correctly.

from cas-security-spring-boot-starter.

Ok but currently the starter is more about integrating CAS client inside Spring boot & Security app.

I don't mean that this feature request will never resolved but since there are missing few integrations (Spring boot 2, RestTemplate, tests & coverage). To be honest with you, since it's possible to override by yourself the TicketValidator, I don't think I will work on that top priority on that request.

Feel free to propose PR.

from cas-security-spring-boot-starter.