CUDA interface change and new function about kaldi HOT 3 CLOSED

Sure. Your instructions are quite straightforward. I'll take it.

X.

On 08/26/2015 09:08 AM, Daniel Povey wrote:

@naxingyu https://github.com/naxingyu, it would be great if you
could help with this because you have been working on similar code
recently. This is something I need for my work on CTC (which I am
working on currently in my personal fork of Kaldi). I'll add you to
the paper if you can help with this.

The following code currently exists in cu-matrix.h:

|// This function, adds a list of MatrixElements (scaled by alpha) to corresponding locations to
// (*this).
void AddElements(Real alpha, const std::vector<MatrixElement >& input);

// This function resizes the output to indexes.size(), and for each element of
// "indexes" it interprets it as a (row, column) index into _this, and puts
// (_this)(row, column) into the corresponding element of "output".
void Lookup(const std::vector &indexes,
std::vector *output) const;
|

What I would like is (1) to change the interface of the existing
Lookup to take a Real* pointer instead of a std::vector, for greater
flexibility, (2) add a version of Lookup that takes CuArray instead,
that would be called internally by the existing function in cases
where CUDA is being used; and (3) add a version of AddElements that is
more compatible with the Lookup interface, as follows (we can add an
alpha to its interface later if it becomes necessary).

| /// For each i, with indexes[i] = (j, k), does (*this)(j, k) += input[i]. Requires, but does
/// not check, that the vector of indexes does not contain repeated elements. 'input'
/// is the start of an array of length equal to indexes.Dim().
void AddElements(const CuArray &indexes, const Real *input);
|

—
Reply to this email directly or view it on GitHub
#94.

from kaldi.

Should I update all the calls to the new interface?

from kaldi.

Yes.

On Tue, Aug 25, 2015 at 11:04 PM, Xingyu Na [email protected]
wrote:

Should I update all the calls to the new interface?

—
Reply to this email directly or view it on GitHub
#94 (comment).

from kaldi.