Kafka instrumentation is not using w3c for context propagation about kamon HOT 6 CLOSED

@ivantopo started a PR but I'm having issues with compiling the project. Any tips would be handy.

from kamon.

Hey @Symbianx,

The Kafka instrumentation is explicitly using a kctx header with Kamon's internal binary encoding for the entire context, including the Span, context tags, and any other context key that has a binary encoder configured. We never thought of using another format because we never had anything else other than Kamon on the other side consuming those messages 😂

Do you know if it is a common practice to use the w3c format in Kafka (or in general, message brokers)? If so, we could definitely look at adding a setting for this.

from kamon.

Thanks for the quick response @ivantopo!

We've been instrumenting java, python and node apps with the opentelemetry packages and they don't make a distinction between http or kafka. The same propagation method is used for both protocols, which by default is W3C.

I don't know what all other vendors are doing but NewRelic seems to be adopting the OpenTelemetry standards as well.

from kamon.

Do you know if it is a common practice to use the w3c format in Kafka (or in general, message brokers)? If so, we could definitely look at adding a setting for this.

I've been looking into this recently and yes, official OT Java instrumentation uses existing TextMapPropagator to inject trace context into Kafka record headers: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/kafka/kafka-clients/kafka-clients-common/library/src/main/java/io/opentelemetry/instrumentation/kafka/internal/KafkaPropagation.java#L53

from kamon.

Thanks for the feedback folks!

@Symbianx going back to this:

If it's not available but wanted, I could make a PR for it.

I can say it is definitely not available, and wanted. Would love to see that PR!

from kamon.

Hey @Symbianx, I noticed you figured out how to fix the build. Feedback coming on the PR soon :)

from kamon.