Logback instrumentation broken with with logback-classic 1.4.x about kamon HOT 6 CLOSED

@ivantopo I've reverted back to the original intercept implementation but switched interception to LoggingEvent.getMDCPropertyMap instead of LogbackMDCAdapter.getPropertyMap:

  onType("ch.qos.logback.classic.spi.LoggingEvent")
    .intercept(method("getMDCPropertyMap"), GetPropertyMapMethodInterceptor)

This seems to work reliably on both Logback 1.2.10 and 1.4.5

from kamon.

Fixed in #1252

from kamon.

Hey @nvollmar, thanks so much for bringing this up! Just to be sure on something, did you have this issue even when using the setting included on #1236? That would be:

kanela.modules.play-framework.order = 3

There were some random problems due to initialization order, but those should have been fixed after adding this setting.

from kamon.

@nvollmar see this comment too: #1234 (comment)

from kamon.

@ivantopo We don’t use play, we build directly on plain Akka.

from kamon.

Thanks for sharing @nvollmarl, I gave it a try on a few applications locally and worked as expected 💪

from kamon.