Giter VIP home page Giter VIP logo

Comments (5)

ivantopo avatar ivantopo commented on May 27, 2024

Also a warning should be logged to let the user know that probably forgot to include the weaver jvm options when starting the app.

from kamon.

magro avatar magro commented on May 27, 2024

We're running into this issue when running tests (our tests / fake app is not instrumented):

2014-12-09 14:09:21,232 ERROR [undefined][akka://KeepJobLockedSpec/system/log2-NewRelicErrorLogger] [KeepJobLockedSpec-akka.actor.default-dispatcher-6] akka.actor.OneForOneStrategy - akka.event.Logging$Error cannot be cast to kamon.trace.TraceContextAware
java.lang.ClassCastException: akka.event.Logging$Error cannot be cast to kamon.trace.TraceContextAware
        at kamon.newrelic.NewRelicErrorLogger$$anonfun$notifyError$1.apply$mcV$sp(NewRelicErrorLogger.scala:44) ~[kamon-newrelic_2.11-0.3.6-20aefb53cae46417335ede27abdb9024b21c4496.jar:0.3.6-20aefb53cae46417335ede27abdb9024b21c4496]

Looking at NewRelicErrorLogger.scala:44 there's (again) an unguarded val ctx = error.asInstanceOf[TraceContextAware].traceContext. Is this a regression, because this should be fixed by commit 6e22e6e?

from kamon.

ivantopo avatar ivantopo commented on May 27, 2024

You are absolutely right, let me fix that quickly.

from kamon.

ivantopo avatar ivantopo commented on May 27, 2024

@magro done, published 0.3.6-1b508ff95ea477387a0b27eae41ee7a76861928e for Scala 2.11 in our snapshots repo, have fun!

from kamon.

magro avatar magro commented on May 27, 2024

@ivantopo Great, works nicely.

from kamon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.