If macro expands to symbol it doesn't go through another EVAL about mal HOT 10 CLOSED

Good catch! That's definitely a bug. I've pushed a soft test for step8 to get travis to do the coverage to determine which ones are broken:: https://travis-ci.org/kanaka/mal/builds/103705447

Not all of them are broken, for example awk and haskell and correct. The problem is that in EVAL after the call to macroexpand, we should call eval_ast if the macro result is not a list rather than just returning the ast.

from mal.

I assume the following paragraph in guide.md should be corrected:

* In the evaluator (`EVAL`) before the special forms switch (apply
  section), perform macro expansion by calling the `macroexpand`
  function with the current value of `ast` and `env`. Set `ast` to the
  result of that call. If the new value of `ast` is no longer a list
  after macro expansion, then return `ast`, otherwise continue with
  the rest of the apply section (special forms switch).

And the process/*.txt files:

EVAL(ast,env):
  while true:
    if not list?(ast): return eval_ast(ast, env)

    ast = macroexpand(ast, env)
    if not list?(ast): return ast

    switch ast[0]:
      'def!:        return env.set(ast[1], EVAL(ast[2], env))
...

from mal.

Yep, exactly.

from mal.

I'm not sure why kotlin is marked as having a fix. The test is soft failing on my end. I'll have a fix shortly.

Edit Ok, I guess kotlin works actually. Never mind. What's failing is running the MAL tests using kotlin as the implementation. Is this a bug with MAL-in-MAL then?

from mal.

@ivern yep, the mal-in-mal implementation is one of the ones that needs fixing.

from mal.

I updated the list to reflect what's been done rather than what's been merged.

from mal.

I just merged the PR and pushed updates for the remaining ones. I also made the test mandatory. I'll close this once travis checks out: https://travis-ci.org/kanaka/mal/builds/104991412

from mal.

Before you close it, the process/step{8,9,A}_*.txt and process/guide.md should be fixed as discussed above in this issue.

from mal.

Yep, thanks for the reminder.

from mal.

Okay, travis passed and I pushed those minor updates.

from mal.