Giter VIP home page Giter VIP logo

Comments (9)

bornova avatar bornova commented on June 2, 2024

Same problem here. Worked great with macos-10.15 but fails to notarize using macos-latest or macos-12. And since macos-10.15 is now deprecated, I am no longer able to notarize my app using Github Actions.

from electron-builder-notarize.

bornova avatar bornova commented on June 2, 2024

UPDATE
Switching to authenticate with username and password (APPLE_ID and APPLE_ID_PASSWORD) instead of API_KEY has resolved the issue for me. Updated my build.yml as follows:

env:
  APPLE_ID: ${{ secrets.apple_id }}
  APPLE_ID_PASSWORD: ${{ secrets.apple_id_password }}

where
APPLE_ID String - The username of your apple developer account
APPLE_ID_PASSWORD String - The app-specific password (not your Apple ID password)

from electron-builder-notarize.

juli1 avatar juli1 commented on June 2, 2024

I have exactly the same issue :(

Even by putting APPLE_ID and APPLE_ID_PASSWORD, I still have the issue.

from electron-builder-notarize.

andyoknen avatar andyoknen commented on June 2, 2024

I'm not sure which of these helped me, but this configuration signs my code and notarizes successfully

- name: Prepare for app notarization
  run: |
    mkdir -p ~/private_keys/
    echo '${{ secrets.APPLE_API_KEY }}' > ~/private_keys/AuthKey_${{ secrets.APPLE_API_KEY_ID }}.p8
    echo '${{ secrets.APPLECERT }}' | base64 -d > applecert.p12
- name: Building
  env:
    APPLEID: ${{ secrets.APPLEID }}
    APPLEIDPASS: ${{ secrets.APPLEIDPASS }}
    API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }}
    API_KEY_ISSUER_ID: ${{ secrets.APPLE_API_KEY_ISSUER_ID }}
    CSC_LINK: 'file://applecert.p12'
    CSC_KEY_PASSWORD: ${{ secrets.APPLECERTPWD }}

from electron-builder-notarize.

rkbhochalya avatar rkbhochalya commented on June 2, 2024

Maybe the problem is not here - but I hope for help, because I can't find a solution yet. Thanks!

  ⨯ The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Error  failedTask=build stackTrace=TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Error

@andyoknen the error handling part in the package is throwing this error. You are not able to see the actual error due to this.

fs.writeFileSync('notarization-error.log', error);

I'll submit a PR with the fix.

from electron-builder-notarize.

juli1 avatar juli1 commented on June 2, 2024

@juli1 thanks! Would love to have more information about what is going on!

from electron-builder-notarize.

juli1 avatar juli1 commented on June 2, 2024

@andyoknen do you still use samuelmeuli/action-electron-builder@v1? Do you mind sharing your entire configuration?

Thanks,

from electron-builder-notarize.

andyoknen avatar andyoknen commented on June 2, 2024

@andyoknen do you still use samuelmeuli/action-electron-builder@v1? Do you mind sharing your entire configuration?

I'm sorry, I mixed up the workflow - in the example above, I use electron-builder to build. Here is my action to build the release now - it looks like everything is fine with it now. I think I fixed the notarization for a long time, but I don't remember exactly how :)

https://github.com/pocketnetteam/pocketnet.gui/blob/master/.github/workflows/build.release.yml

from electron-builder-notarize.

andyoknen avatar andyoknen commented on June 2, 2024

I think the issue can be closed - my question is exhausted

from electron-builder-notarize.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.