Install from fork, problems with adapter.js about karma-jasmine HOT 4 CLOSED

@23tux As you correctly pointed adapter.js generated by grunt build.
adpater.js placed only in npm repository when we run grunt release.

If you want use your version of karma-jasmine then you can remove lib/adapter.js from .gitignore.
If you want test you changes you can(should) write test :)

Thanks!

from karma-jasmine.

@23tux - @maksimr explanations are spot on - you would have to build & publish build output if you want to pull plugin from GitHub. Having said this the more important question is - did you bump into a bug / missing future that forced you to fork? If so, maybe it would be better to send a pull request to this repository, so other members of the community can benefit from the update?

Contribution guidelines are outlined here: http://karma-runner.github.io/0.12/dev/contributing.html

from karma-jasmine.

@maksimr thx, I'll check this out.

@pkozlowski-opensource Yes, I was planning sending a PR, but before that, I want to be sure, that everything works as expected, including the installation stuff (and there, I encountered this issue).

I added some pretty print diff for the console output, and added some color formatting. But, because I'm using Jasmine 1.x, I'll created a branch out of the v0.1.5 tag and added the color highlighting there. Is it possible, to only send the pull request for this version? Or are pull requests only accepted for the newer v0.2.x version of karma-jasmine?

from karma-jasmine.

@23tux version 0.1.5 of the karma-jasmine lives in this branch: https://github.com/karma-runner/karma-jasmine/tree/jasmine-1_0 so you can send your PR agains that branch. My understanding that both branches (for jasmine 1.x and 2.x) are maintained so your PR could be accepted.

from karma-jasmine.