Giter VIP home page Giter VIP logo

Comments (6)

martin-g avatar martin-g commented on May 30, 2024

http://jsfiddle.net/1uc4feys/4/

Here is the fiddle.
The problem happens when there is a <label> around the <input>.

from bootstrap-checkbox-x.

kartik-v avatar kartik-v commented on May 30, 2024

Even though base input is hidden - the label when clicked should trigger the change event for the checkbox plugin (just like a normal html checkbox).

So if you check the demo - clicking on the label will also toggle the checkbox.

Your problem is the use case where you are enveloping the label over the checkbox. Let me see if there is an option to add.

from bootstrap-checkbox-x.

martin-g avatar martin-g commented on May 30, 2024

Right. I think https://github.com/kartik-v/bootstrap-checkbox-x/blob/master/js/checkbox-x.js#L44 should stop the event propagation before calling change(). Otherwise the event bubbles to the enveloping <label> and triggers the click second time.

from bootstrap-checkbox-x.

martin-g avatar martin-g commented on May 30, 2024

But maybe there are use cases where the event should bubble ?!

from bootstrap-checkbox-x.

kartik-v avatar kartik-v commented on May 30, 2024

Plugin is upgraded to release v1.1.0. There is a new boolean property added - labelClickEvent which defaults to true. If set to false, it will not trigger the change event on label click.

from bootstrap-checkbox-x.

martin-g avatar martin-g commented on May 30, 2024

Thanks!
Works like a charm!

from bootstrap-checkbox-x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.