Giter VIP home page Giter VIP logo

Comments (5)

davideme avatar davideme commented on June 28, 2024

Proposal for HTTPClient, change name of send to execute, and provide a default implementacion of send that used the Interceptors/Middlewares.

protocol HTTPClient {
    let middlewares: [Middleware] { get }

    func execute(httpRequest: HTTPRequest) -> Future<HTTPResponse, NSError>
}

extension HTTPClient {
    func send(httpRequest: HTTPRequest) -> Future<HTTPResponse, NSError> {
        /* Call array of middleware processRequest */
        self.execute()
        /* Call array of middleware processResponse */
    }
}

from bothamnetworking.

pedrovgs avatar pedrovgs commented on June 28, 2024

Cool! I'm going to change the name from Middleware to another thing xD but I guess the approach is ok. Another interesting point is that we will have to change HTTPRequest class to be mutable.

from bothamnetworking.

davideme avatar davideme commented on June 28, 2024

Yes I was thinking about that, and maybe there is a way to keep HTTPRequest Immutable.

from bothamnetworking.

davideme avatar davideme commented on June 28, 2024

i don't remember which language use this maybe F#, be we could, add methods to HTTPRequest that help modify only one properties.

func withHeaders(headers: [String:String]) -> HTTPRequest {
    return HTTPRequest(self.url, self.parameters, headers, self.httpMethod, self.body)
}

We keep it immutable and it's easy to modify.

from bothamnetworking.

pedrovgs avatar pedrovgs commented on June 28, 2024

I'm working on it.

from bothamnetworking.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.