Comments (5)
Proposal for HTTPClient, change name of send to execute, and provide a default implementacion of send that used the Interceptors/Middlewares.
protocol HTTPClient {
let middlewares: [Middleware] { get }
func execute(httpRequest: HTTPRequest) -> Future<HTTPResponse, NSError>
}
extension HTTPClient {
func send(httpRequest: HTTPRequest) -> Future<HTTPResponse, NSError> {
/* Call array of middleware processRequest */
self.execute()
/* Call array of middleware processResponse */
}
}
from bothamnetworking.
Cool! I'm going to change the name from Middleware
to another thing xD but I guess the approach is ok. Another interesting point is that we will have to change HTTPRequest class to be mutable.
from bothamnetworking.
Yes I was thinking about that, and maybe there is a way to keep HTTPRequest Immutable.
from bothamnetworking.
i don't remember which language use this maybe F#, be we could, add methods to HTTPRequest that help modify only one properties.
func withHeaders(headers: [String:String]) -> HTTPRequest {
return HTTPRequest(self.url, self.parameters, headers, self.httpMethod, self.body)
}
We keep it immutable and it's easy to modify.
from bothamnetworking.
I'm working on it.
from bothamnetworking.
Related Issues (20)
- Encoding Body
- Add NSLogInterceptor HOT 3
- HTTPRequest and HTTPResponse constructors are not public.
- HTTPClient default timeout.
- Update default HTTPResponse validation to use only statusCode and not HTTPResponse headers.
- URL Params Encoding
- BothamAPIClient should parse connection errors.
- Response Interceptor need a retry request mechanism HOT 4
- Define an HTTPClient protocol HOT 1
- Mapping of BothamAPIError is done in NSHTTPClient and HTTPClient HOT 4
- Support as input multiple headers with the same key HOT 1
- Provide an Interceptor or an example how to set default URL parameters HOT 1
- Be able to specify NSURLSessionConfiguration
- Converter or Formater
- Be able to Parse HTTP Error Body and return domain specific error
- Authentication
- Parameter Encoding
- Improve BothamAPIClient validation to include content type.
- Add input values validation. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bothamnetworking.