Comments (5)
Thanks for reporting the issue!
The prettify.css
is loaded via JS instead of wp_enqueue_script()
so it shouldn't be possible for concatenation plugins to include it in the bundle. I'm not seeing the issue with https://github.com/kasparsd/minit for example.
You bring up a good point, though -- that preload only makes sense when the prettify.css
is going to be actually used. I wonder if the prettify library loads it on every page or we're triggering false preloads when the CSS file isn't actually needed.
from code-prettify.
Thank you for the quick response. I worked around the issue by commenting prettify_preload_code_styles
from code-prettify.
I just posted an alternative solution in the wiki that should allow you to keep the plugin updated and have the preload disabled.
Also, could you please confirm if and how prettify.css
get's included in the FVM bundle even when it's added via JS? Is that because of that preload rule?
from code-prettify.
Also, could you please confirm if and how
prettify.css
get's included in the FVM bundle even when it's added via JS? Is that because of that preload rule?
It's <link rel="preload">
inlined into the page's html. The FVM bundle already includes prettify.css, so removing the preloader doesn't affect functionality.
from code-prettify.
Shouldn't it remove the preload tag if it already inlined its content?
from code-prettify.
Related Issues (20)
- Add Code Tag HOT 1
- Plugin can't read '<' character HOT 2
- Simplify adding code in post content
- Plugin seems to be replacing the font HOT 3
- Automatic Escaping
- Please update languages HOT 1
- Code snippets displays wrong on narrower screens HOT 6
- Add a couple of hooks HOT 2
- colors...
- Not support for xml format HOT 2
- Not working with WP 5.0 HOT 2
- Triggered a fatal error. HOT 3
- Add scrollbars when needed (or configured)
- Not working properly with Wordpress blocks (Gutenberg) HOT 1
- Preload prettify.css for performance
- Missing C# HOT 1
- wp_localize_script $l10n should be a array in wordpress 5.7.0 HOT 2
- Minit plugin compatibility HOT 4
- Suggestions regarding to the Readme.txt HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from code-prettify.