Giter VIP home page Giter VIP logo

Comments (5)

kamyar1979 avatar kamyar1979 commented on July 18, 2024 3

Too many + operators for immutable type! Use string format instead:
url = 'https://{}/{}/{}/{}/{}.json'.format(self.host, self.version, self.apikey, action, method)

from kavenegar-python.

kamyar1979 avatar kamyar1979 commented on July 18, 2024 3

Actually, the whole code and even API is bullshit! REST API must get Json/XMl/... not Form Data! Variable names obey none of naming conventions! (Variables with multiple words are not separated neither with letter case nor with _) The SDK code is very BAD! No OpenAPI! Errors do not change HTTP Status code! Event a single search in google would make anything better! It is really 'khosolati'!

from kavenegar-python.

kamyar1979 avatar kamyar1979 commented on July 18, 2024 2

We do not use this piece of shit! Instead we created a Swagger and use some swagger invoker!

from kavenegar-python.

torkashvand avatar torkashvand commented on July 18, 2024 1

please refactor this piece of shit! I prefer to write my own code! don't waste our time

from kavenegar-python.

rezaxd avatar rezaxd commented on July 18, 2024

Hello @kamyar1979 !
I created PR that fixed this.
hope u feel better, like me. :D

from kavenegar-python.

rezaxd avatar rezaxd commented on July 18, 2024

Sometime you don't have enough time for doing stuff by urself.
I agree with you that the API sucks.
But... IDK! :(((

from kavenegar-python.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.