undefined hardware_destructive_interference_size about openal-soft HOT 5 CLOSED

It seems to be a bug in older versions of Clang/LLVM/libc++. I currently have the Andoid NDK r25c installed, and I see it define:

# define __cpp_lib_hardware_interference_size           201703L

in <version>, but doesn't declare hardware_destructive_interference_size anywhere, so adding a value check won't fix it. It's simply defined when it shouldn't be. Seems a better fix would be to test if it's building against affected versions of libc++, though I don't know what to check _LIBCPP_VERSION against for the fix.

Commit 28f7b53 should work around it by not using hardware_destructive_interference_size at all on libc++.

from openal-soft.

Upon some light inspection, perhaps this line is incorrect?
https://github.com/kcat/openal-soft/blob/master/common/ringbuffer.h#L23

According to https://stackoverflow.com/a/60004979/1709725
should be

#if __cpp_lib_hardware_interference_size >= 201603

from openal-soft.

rigtorp/SPSCQueue#22

some similar issues

from openal-soft.

Thank you, confirming builds are passing again!

from openal-soft.

Would perhaps also be great to have an android build in the github workflows!

from openal-soft.