confusing error message for forgetting to wrap a string in quotes about kdl-rs HOT 6 CLOSED

For reference I am constantly making this mistake typing out examples for kdlscript because I made it look SO CLOSE to rust that my brain forgets I'm writing kdl lol.

from kdl-rs.

oh this one's gonna be tricky to get a good error out of 🤔

from kdl-rs.

I think maybe one good way to detect it is to extend the internal grammar to accept idents in argument position and then emit an error whenever you successfully parse such an item.

But I'm not sure if there's some fundamental ambiguity you're trying to avoid by requiring quoting of strings.

from kdl-rs.

No, I think your idea might actually work pretty well! I can't think of anything in the grammar that would prevent idents from being treated as string values.

from kdl-rs.

Nice I got it working!

Before

Error: 
  × Expected valid node terminator.
   ╭─[7:1]
 7 │
 8 │ struct Vec { }
   · ───┬───
   ·    ╰── parsed node
   ╰────
  help: Nodes can only be terminated by `;` or a valid line ending.

After

thread 'parser::node_tests::errant_ident' panicked at 'failed to parse:
  × Expected a valid node entry.
   ╭────
 1 │ struct Vec { }
   ·        ─┬─
   ·         ╰── plain identifiers can't be used here
   ╰────
  help: If this was supposed to be a string, wrap it in quotes.
        If this was supposed to be a new node, terminate the previous node with `;` or `}`

from kdl-rs.

This feature has been tagged and released as [email protected] :)

from kdl-rs.