Giter VIP home page Giter VIP logo

Comments (1)

wozniakjan avatar wozniakjan commented on July 27, 2024

ah, never mind, looks like this is by design

http-add-on/pkg/queue/bucketing.go

Lines 105 to 118 in 1e27b39

case d < t.window:
// If we haven't received metrics for some time, which is less than
// the window -- remove the outdated items and divide by the number
// of valid buckets
stIdx := t.timeToIndex(t.lastWrite)
eIdx := t.timeToIndex(now)
ret := t.windowTotal
for i := stIdx + 1; i <= eIdx; i++ {
ret -= t.buckets[i%len(t.buckets)]
}
numB := math.Min(
float64(t.lastWrite.Sub(t.firstWrite)/t.granularity)+1, // +1 since the times are inclusive.
float64(len(t.buckets)-(eIdx-stIdx)))
return roundToNDigits(precision, float64(ret)/numB)

I'd still like to make an argument that the RPS should decrease if the traffic goes to zero. At the moment, as implemented, if traffic drops from 10 to 0 RPS, it yields a higher RPS metric compared to traffic dropping from 10 to 1 RPS. This intuitively doesn't feel correct to me.

wdyt @JorTurFer, @zroubalik?

from http-add-on.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.