Giter VIP home page Giter VIP logo

Comments (6)

noklam avatar noklam commented on June 9, 2024

One question here, we tend to do the breaking change later in develop to avoid the code diverge too much. At the same time should we add the deprecated warnings earlier in 0.19 to inform user?

This is not important for this particular issue, because I think no one use it (hopefully), but it is a valid question for what should we do in general?

from kedro.

astrojuanlu avatar astrojuanlu commented on June 9, 2024

should we add the deprecated warnings earlier in 0.19 to inform user?

Yes

from kedro.

noklam avatar noklam commented on June 9, 2024

from kedro.

astrojuanlu avatar astrojuanlu commented on June 9, 2024

I'd say let's rename this ticket to "Deprecate get_pkg_version" and groom it

from kedro.

noklam avatar noklam commented on June 9, 2024

Actually the tests are obsoleted and we should remove it altogether class TestCliUtils in test_cli.py.

from kedro.

astrojuanlu avatar astrojuanlu commented on June 9, 2024

Funny bit of insight found in the source code of kedro-mlflow:

            # if it is a local relative path, make it absolute
            # .resolve() does not work well on windows
            # .absolute is undocumented and have known bugs
            # Path.cwd() / uri is the recommend way by core developpers.
            # See : https://discuss.python.org/t/pathlib-absolute-vs-resolve/2573/6

Not sure how up to date it is though (the thread is from 2019).

from kedro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.