Giter VIP home page Giter VIP logo

Comments (61)

douwefokkema avatar douwefokkema commented on July 17, 2024

Is this reproducible and consistent each time you start O after shutting down with running radar? Do you have a log file of this happening? Can you make a log with VerboseLog=63 in the ini file.
I can not reproduce this.

from br24radar_pi.

Hakansv avatar Hakansv commented on July 17, 2024

Win10: I've shut down with a live radar several times without subsequent crashes.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

image

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

....
8:02:15 AM: BR24radar_pi: SetNMEASentence $AIMWV,1.6,R,12.9,N,A*08
8:02:15 AM: BR24radar_pi: RenderGLOverlay context=00000000
8:02:15 AM: BR24radar_pi: Automatic range changed from 0 to 423 meters
8:02:15 AM: BR24radar_pi: Radar A transmit: range 231 meters
8:02:15 AM: Error: BR24radar_pi: Unable to transmit command to unknown radar
8:02:15 AM: BR24radar_pi: RenderRadarOverlay lat=12.0027 lon=-61.7351 v_scale_ppm=2.22679 vp_rotation=0 skew=0 scale=1754.588013 rot=0

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

This is consistently repeatable.
Win 10 Home 1607

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

Found another issue, please download from the same link above.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

That works better. Can restart OK RADAR starts, but when I zoom in and then out it crashes.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

nahanniv-log.zip

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

Why do others not have this problem ?

from br24radar_pi.

douwefokkema avatar douwefokkema commented on July 17, 2024

I am really puzzled. Please try also with VerboseLog= 0, there is a chance that all the logging itself influences results.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

Tried with VeboseLog=0

It Immediate crashes on restarting after shutting down with RADAR on.

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

Tried shutting down with range 36NM and gain 0 a few times.

Seems to take longer before crashing when restarted.

It usually seems to crash when zooming in and out.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

Here is my OpenCPN.ini file after shutting down with the radar on:

nahanniv-opencpn.zip

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

Is anyone else able to reproduce this problem ?

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

from br24radar_pi.

Hakansv avatar Hakansv commented on July 17, 2024

I'm on Win10 and as said no similar experiences but havn't stressed extensively zooming lately. I'll take present code for a live test on board now and revert.

from br24radar_pi.

Hakansv avatar Hakansv commented on July 17, 2024

Been testing also the latest code on my BR24 using Win10 and O 4.8.
I can still close O with an active radar and restart wo any issues. The radar is directly transmitting after restart.
Zoom in/out is also fine wo issues although my BR24 is in AUTO limited to 24 NM range.

One note though; In radarwindow, after "North up" is "Course up" still viewing north up but next level "Course up (Stabilized)" shows heading up. I use HDG from external compass via O NMEA and WMM.

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

Douwe reports that he has a crash, but that is not reproducible by me.

I did fix a number of 'trails' issues in zooming in. These are fixed in the following:

https://www.dropbox.com/s/0pc7ablmojqw44x/br24radar_pi-3.909-win32.exe?dl=0

Can you try again?

If this still crashes, please make a copy of your ini file and remove the entire [AUI] section, this contains the onscreen location for the AUI manager that controls the different panes, then try again.

We saw that you had Radar A at a negative offset. Do you use multiple screens?

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

I shortened this issue by putting the logs and ini files in zip files and attaching those to the comment.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

The latest version will not load.

Shows Incompatible in the plugin configuration.

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

Latest version crashed immediately on restart.

then I deleted [AUI] section from .ini file.

Restarted OK, but crashed when scrolling out.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

The automatically re-created [AUI] section
[AUI]
AUIPerspective=layout2|name=ChartCanvas;caption=;state=768;dir=5;layer=0;row=0;pos=0;prop=100000;bestw=1920;besth=997;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=BR24radar_pi-0;caption=Radar A;state=2099151;dir=4;layer=0;row=0;pos=0;prop=100000;bestw=960;besth=540;minw=256;minh=256;maxw=-1;maxh=-1;floatx=-506;floaty=163;floatw=512;floath=512|name=BR24radar_pi-1;caption=Radar B;state=2099151;dir=4;layer=0;row=0;pos=0;prop=100000;bestw=960;besth=540;minw=256;minh=256;maxw=-1;maxh=-1;floatx=1816;floaty=-3;floatw=512;floath=512|name=7b2effff-a543-41eb-b18f-fe59489cffff;caption=Dashboard;state=2098127;dir=4;layer=0;row=0;pos=0;prop=100000;bestw=150;besth=842;minw=150;minh=842;maxw=-1;maxh=-1;floatx=100;floaty=100;floatw=166;floath=881|dock_size(5,0,0)=398|

from br24radar_pi.

douwefokkema avatar douwefokkema commented on July 17, 2024

I can now fully reproduce your crash (that is: start up with running radar) using your ini file. With the new version of Kees it is no longer crashing always but sometimes. I did another mod that solves the crash with me completely. But that does not mean it solves the problem on your system. Test version at https://www.dropbox.com/s/skwxn7cmrbvz114/br24radar_pi-3.908-win32-test.exe?dl=0 . Dll only at: https://www.dropbox.com/s/wb50m26ock7n5em/br24radar_pi.dll?dl=0 But when you wait a bit, Kees might have a better implementation.
Source is on https://github.com/douwefokkema/BR24radar_pi/tree/master1

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

Douwe, I downloaded the .exe version, but it did not fix the issue on my system.
Tried it twice and it crashed almost immediately (without any action from me).

What was the problem you fixed ?
I have re-enabled and located my dashboard display after deleting the [AUI] section of my .ini file, but everything else is the same.

from br24radar_pi.

douwefokkema avatar douwefokkema commented on July 17, 2024

I did put a wait in the processing of the received data from the radar until all transmit sockets were ready. It seemed that the system when started with running radar started processing before all inits were done. Earlier this produced error messages.
Problem now is that I can't reproduce your errors any longer (after my update). As I could only reproduce with your opencpn.ini, there seems to be a dependency on the ini file. Could you try to throw away (rename) yr opencpn.ini and let OpenCPN make a new one. You will have to set comms and chart settings again. Please let me have again the opencpn.log made with VerboseLog=1.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

Content moved to attachment.
nahanniv_log4.txt

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

OK, I deleted my OpenCPN.ini file.
enabled OpenGL
added connection for NMEA data
Enabled radar plugin.

turned on RADAR
closed OpenCPN
Re Opened OpenCPN

Crash !

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

VerboseLog=1
I had to zoom in and out before it crashed;
Sometimes it crashes without any user input, other times it crashes when I zoom in/out

08:13:07: 

________
08:13:07: 2017-09-10
08:13:07:  ------- Starting OpenCPN -------
08:13:07: Version 4.8.0 Build 2017-08-11
...
8:13:15 AM: BR24radar_pi: main timer
8:13:15 AM: BR24radar_pi: main timer
8:13:16 AM: BR24radar_pi: main timer
8:13:16 AM: BR24radar_pi: Radar reports status STANDBY
8:13:16 AM: BR24radar_pi: main timer
8:13:16 AM: BR24radar_pi: main timer
8:13:16 AM: BR24radar_pi: main timer
8:13:16 AM: BR24radar_pi: SetPositionFixEx var=-14.000000 var_wd=1
8:13:16 AM: BR24radar_pi: main timer
8:13:16 AM: BR24radar_pi: main timer
8:13:16 AM: BR24radar_pi: main timer
8:13:16 AM: BR24radar_pi: main timer
8:13:16 AM: BR24radar_pi: main timer

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

Could there be something about my hardware ?

http://minix.com.hk/en/products/neo-z83-4

It has Intell Graphics; I know OpenCPN has several exceptions for OpenGL when running on Intell Graphics ?

from br24radar_pi.

douwefokkema avatar douwefokkema commented on July 17, 2024

I am testing ow on a Intel I7 with simulated radar, so I can not zoom in/out myself, but the simulation contains many zooms. I will dust off an older Atom based laptop and try on that with the real radar, mid of the week I expect to be on board. And yes, there are issues with Windows Creator version and Intel graphics with OpenGL.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

I don't have creator version yet. I'm at 1607.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

I also have heading by Serial (USB) and quite a few AIS targets.

Here is a sample of my Serial data:
nahanniv_nmea.txt

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

John, can you please upload files instead of copy/pasting long strings in took keep the issue readable?

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

It has Intell Graphics; I know OpenCPN has several exceptions for OpenGL when running on Intell Graphics ?

That was mostly related to the '500' hardware in the original Atom, which was utter crap. The Intel HD is not that bad actually.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

I'm in a remote anchorage at the limit of WiFi connectivity.
I have tried to upload files, but usually cutting and pasting text into the comment has a better chance of posting.
Sorry,
JM.

from br24radar_pi.

douwefokkema avatar douwefokkema commented on July 17, 2024

Just another try. Here: https://www.dropbox.com/s/bswvb062vehklj6/br24radar_pi-2.3-5c778bb-win32.exe?dl=0 is the version from June this year which I used all summer. It does not have the ARPA and AIS targets on the radar windows yet. Interesting to know if problem is there as well.

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

Also, AIS target count for you is relatively low. My AIS target count is 210, and this does not cause any issues, other than looking ugly:

screen shot 2017-09-10 at 17 39 30

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

ok helgrind has found some unprotected cross-thread access, preparing a fix quickly.

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

And here is the location for the latest build, with various small issues regarding memory and threading fixed.

https://www.dropbox.com/s/kzslq4fijwa68bl/br24radar_pi-3.910-win32.exe?dl=0

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

The old version did not crash.

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

And new 3.910 version? If it does crash, is this still related to the radar being on, or does it also crash if you turn the radar off, shutdown/start O, turn radar on? I can't see any code path that would make it different when the radar is already on, but we've been proven wrong for days ;-)

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

I've just updated the 3.910 version with one that can hide the AIS and MARPA targets on the PPI window. Basically that is the biggest difference between Douwe's June version and the production release.

Can you test with:

  • Only one radar enabled (I think you already run like this)
  • AIS/ARPA targets hidden (you can find this on the PPI menu View > Show/Hide AIS/ARPA)

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

The new version is not crashing.

Some remaining questions:

1/ after copying back my original OpenCPN.ini file I was unable to get the RADAR A PPI window to display ? Tried deleting all the RADAR settings from the ini file, but then could not get the RADAR to work at all ? How did it get into this state ?

2/ Your picture shows AIS target names on the PPI window. Mine is not showing names?

from br24radar_pi.

douwefokkema avatar douwefokkema commented on July 17, 2024

Using your ini file I also had the radar A window hidden. It was outside the visible area. Go inside the ini file and find Radar0WindowPosX= In my case this was -604, that is outside the visible area. Make it 100 or so. After running O, I found this position being reset to its previous value again, that was the value of the first floatx of the [AUI] section. Also correct this floatx to some decent value; 0 or 100, and all remained OK, radar A window visible again. Don't ask me why.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

OK, got the PPI window back. That happened sometime after updating to latest OpenCPN and plugin.

Should the plugin be displaying AIS target names on the PPI window as in the example posted by Canboat ? Or is that a test version ?

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

Sorry If I closed this prematurely.
I was fairly certain it had been fixed.

I think a problem may have been introduced in one of the intermediate builds that I have been testing, but I have no way to go back to test this theory.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

@douwefokkema the crash only seems to happen if the scanner is still on when OpenCPN is re-started.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

@douwefokkema were you able to reproduce this crash ?

@canboat if I am the only one experiencing this crash, can we use the crash report mechanism to get you more details ? Or, is there anything else I can do to help debug it ?

from br24radar_pi.

douwefokkema avatar douwefokkema commented on July 17, 2024

Yes, I can reproduce now and then (on the boat), time consuming. But working on it right now.

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

from br24radar_pi.

douwefokkema avatar douwefokkema commented on July 17, 2024

I found a possible divide by zero, corrected it, but this was not the cause of the crash.
Then I found a possible array boundary violation when zooming and corrected it. But this was not the cause of the crash.
Then I found another array boundary violation, index had strange value, as if it was not initialized. But according to code and log it was initialized. But then I found that with running radar receive thread starts receiving and processing before all initialization is done on the main thread (on a slower computer). So I put the initialization (ClearTrails) also in the start of the receive thread. Problem solved here.
Please try https://www.dropbox.com/s/wb50m26ock7n5em/br24radar_pi.dll?dl=0
But... I worked in the true trails section and can only test true trails when the ship moves again, in a few days.
And the code is on https://github.com/douwefokkema/BR24radar_pi/tree/crash_update

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

@douwefokkema Looks Good on my computer so far, will continue to test.
Thanks.

from br24radar_pi.

douwefokkema avatar douwefokkema commented on July 17, 2024

The cause of the crash (early start of receive) that I indicated yesterday was wrong. Kees hinted me that the position might be invalid while shown as valid. This was indeed the case.
New version https://www.dropbox.com/s/25lb561uw82wci4/br24radar_pi.dll?dl=0
Sources same location as above.

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

@douwefokkema tried the new version, have not been able to get it to crash. The last version did not crash either.

from br24radar_pi.

keesverruijt avatar keesverruijt commented on July 17, 2024

Added some other fixes, this should be the final release if it does not break anything:

https://www.dropbox.com/s/jq9osfhcm5dim6k/br24radar_pi-3.923-win32.exe?dl=0

from br24radar_pi.

NAHANNIV avatar NAHANNIV commented on July 17, 2024

@canboat can't find anything broken in latest version.

from br24radar_pi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.