Giter VIP home page Giter VIP logo

Comments (3)

KelvinTegelaar avatar KelvinTegelaar commented on August 24, 2024

All passwords are send URL Encoded and only decoded right before saving. Have you seen this to be an issue and could you let me know how to reproduce? :)

from azpwpush.

shellster avatar shellster commented on August 24, 2024

If someone uses the Web Application, they will not run into problems. This issue is strictly around preventing accidental user error. Observe the following request:

Invoke-WebRequest -Uri https://pw.cyberdrain.com/create -Method POST -Body 'password=Thiswill=break'

Obviously, this is a user mistake (not URL encoding the parameter), but it is a fairly understandable mistake, hence in my PR why I explicitly check for "=" and store everything after the first one. If you don't believe it to be a serious enough issue, I definitely understand.

from azpwpush.

KelvinTegelaar avatar KelvinTegelaar commented on August 24, 2024

Good call, this actually makes me think of creating another endpoint for programmatic access too. I'll integrate your changes.

from azpwpush.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.