Where is ZF1 and ZF2 frameworks? about php-framework-benchmark HOT 23 CLOSED

+1

from php-framework-benchmark.

I added ZF 2.4 source code: https://github.com/kenjis/php-framework-benchmark/commits/master/zf-2.4
But I've never used ZF as a framework. Is this okay?

from php-framework-benchmark.

I updated the results: https://github.com/kenjis/php-framework-benchmark#hello-world-benchmark

I'm sorry I'm not interested in ZF1.

from php-framework-benchmark.

Even ZF1 was EOL but there are many companies in Japan are using it, is it possible add ZF1 support? We want do performance tuning based on these scores. Thank you anyway.

from php-framework-benchmark.

Also ZF3 was released and it's great!

from php-framework-benchmark.

I have added ZF3 config
#68

from php-framework-benchmark.

@axot You can fork this repository and add ZF1.
But if you send PR, I would merge it.

from php-framework-benchmark.

Okay, I will send a PR in a few days

from php-framework-benchmark.

I could add ZF1 to my ZF3 PR #68

from php-framework-benchmark.

@seyfer I'm appreciate if you cloud add ZF1 !

from php-framework-benchmark.

better create a separate PR, its easier to review.

from php-framework-benchmark.

Please don't add ZF1 to the ZF3 PR.

from php-framework-benchmark.

@cebe @kenjis sorry, I saw your comment too late and have added zf1 to my PR already.

But there almost nothing to review. Only _benchmark folders in zf-3.0 and zf-1.12.
I have checked and tested all configs, it's work fine.

If it still should be separated, how I can do it?

from php-framework-benchmark.

I have stopped pulling and it wasn't added to zf3 PR.

I need to create different branch for ZF1 PR ?

from php-framework-benchmark.

@cebe @kenjis ok, there is separated PR for ZF1
#69

from php-framework-benchmark.

Also I have closed #68 in order to switch PR to zf3 branch from my forked repo. New one for ZF3 is #70

from php-framework-benchmark.

@seyfer @axot Hey, #69 has 9,925 files. Is it really okay?

from php-framework-benchmark.

The full version of ZF1 has almost 10k files...

from php-framework-benchmark.

@kenjis , maybe it would be better to add zf1 files as a zip (or another archive type) and unzip it during setup process?

from php-framework-benchmark.

@seyfer Is there no installation via Composer? If not, the PR is okay.

from php-framework-benchmark.

@kenjis It could be done via Composer, but I need to change some files (like index.php) by hands to provide right path to ZF1 lib, which will be installed in vendor. By default ZF1 project doesn't look into vendor directory.

I will do it and will change my PR.

from php-framework-benchmark.

du -h --max-depth=1 ./ 
56M	./vendor

from php-framework-benchmark.

I have replaced previous commit using git --force option. Please check if it's ok or I need create new PR.

from php-framework-benchmark.