Hello I'm trying to add a 1sec delay between each instance insertion

On the second pass through the loop I get this exception : <a target="_blank" rel=

It works by doing this: <div class="highlight highlight-source-cs notranslate posi

Task dalay about revit.async HOT 21 CLOSED

grizoood commented on May 21, 2024

Task dalay

from revit.async.

Comments (21)

KennanChan commented on May 21, 2024

try to dispose the transaction manually rather than relying on the "using" statement.

from revit.async.

KennanChan commented on May 21, 2024

Or you can create a transaction in every loop

from revit.async.

grizoood commented on May 21, 2024

On the second pass through the loop I get this exception :

 await RevitTask.RunAsync(
                            async app =>
                            {
                                try
                                {
                                    var document = app.ActiveUIDocument.Document;

                                    int count = 20;

                                    for (int i = 0; i < count; i++)
                                    {
                                        string family_2d = "Family";
                                        string symbol_2d = "Symbol";

                                        using (Transaction transaction = new Transaction(document))
                                        {
                                            transaction.Start("Insert");

                                            var symbol = document.FindSymbol(family_2d, symbol_2d);

                                            FamilyInstance instance = document.Create.NewFamilyInstance(new XYZ(0, 0, 0), symbol, StructuralType.NonStructural);

                                            await Task.Delay(1000);

                                            transaction.Commit();
                                        }

                                        Informations = $"Insert {i + 1}/{count}";
                                    }

                                    Informations = "Finished";
                                }
                                catch (Exception ex)
                                { }
                            });

from revit.async.

KennanChan commented on May 21, 2024

How about delaying after the transaction has been committed?

from revit.async.

grizoood commented on May 21, 2024

I tried too but it causes the same exception, for your information it happens on this line: " transaction.Start("Insert");"

from revit.async.

KennanChan commented on May 21, 2024

What is the exception?

from revit.async.

grizoood commented on May 21, 2024

The 1st transaction is commited but the next one does not work.

The exception is: "Starting a transaction from an external application running outside of API context is not allowed." and this happens at the line: " transaction.Start("Insert");"

await RevitTask.RunAsync(
                            async app =>
                            {
                                try
                                {
                                    var document = app.ActiveUIDocument.Document;

                                    int count = 20;

                                    for (int i = 0; i < count; i++)
                                    {
                                        string family_2d = "Family";
                                        string symbol_2d = "Symbol";

                                        using (Transaction transaction = new Transaction(document))
                                        {
                                            transaction.Start("Insert");

                                            var symbol = document.FindSymbol(family_2d, symbol_2d);

                                            FamilyInstance instance = document.Create.NewFamilyInstance(new XYZ(0, 0, 0), symbol, StructuralType.NonStructural);

                                            transaction.Commit();
                                        }

                                        await Task.Delay(1000);

                                        Informations = $"Insert {i + 1}/{count}";
                                    }

                                    Informations = "Finished";
                                }
                                catch (Exception ex)
                                { }
                            });

from revit.async.

KennanChan commented on May 21, 2024

Exactly. The Task.Delay() results in the rest code to be running in a worker thread. You can try to use RevitTask.RunAsync in the loop to execute Revit API

from revit.async.

grizoood commented on May 21, 2024

It works by doing this:

try
{
    int count = 20;

    for (int i = 0; i < count; i++)
    {
        string family_2d = "Family";
        string symbol_2d = "Symbol";

        await RevitTask.RunAsync(
            app =>
            {
                Informations = $"Insert {i + 1}/{count}";

                var document = app.ActiveUIDocument.Document;

                using (Transaction transaction = new Transaction(document))
                {
                    transaction.Start("Insert");

                    var symbol = document.FindSymbol(family_2d, symbol_2d);

                    FamilyInstance instance = document.Create.NewFamilyInstance(new XYZ(0, 0, 0), symbol, StructuralType.NonStructural);

                    transaction.Commit();
                }
            });

        await Task.Delay(1000);
    }

    Informations = "Finished";
}
catch (Exception ex)
{
}

I was thinking of creating a single transaction for the loop how can I do that? Will creating multiple transactions impact processing time?

Another question: If I want to update the "Information" property of my viewmodel, in RevitTask.RunAsync, I have to use the Dispatcher of my interface and do this:

public void UpdateInformations(string message)
{
    _dispatcher.Invoke(() =>
  {
      Informations = message;
  }, DispatcherPriority.Background);
}

from revit.async.

KennanChan commented on May 21, 2024

As far as I know, you can update viewmodel properties without caring about which thread your code is currently running. The viewmodel fires the "PropertyChanged" event to notify the UI to update in proper time.

from revit.async.

KennanChan commented on May 21, 2024

try
{
  RevitTask.RunAsync(async (app) =>
  {
    int count = 20;

    var document = app.ActiveUIDocument.Document;
    Transaction transaction = new Transaction(document);
    transaction.Start("Insert");

    var symbol = document.FindSymbol(family_2d, symbol_2d);

    for (int i = 0; i < count; i++)
    {
      string family_2d = "Family";
      string symbol_2d = "Symbol";

      await RevitTask.RunAsync(
          app =>
          {
            Informations = $"Insert {i + 1}/{count}";
            FamilyInstance instance = document.Create.NewFamilyInstance(new XYZ(0, 0, 0), symbol, StructuralType.NonStructural);
          });

      await Task.Delay(1000);
    }

    transaction.Commit();
    transaction.Dispose();

    Informations = "Finished";
  });
}
catch (Exception ex)
{
}

How about this?

from revit.async.

grizoood commented on May 21, 2024

I get this exception: "System.Runtime.InteropServices.SEHException : 'Un composant externe a levé une exception.'"

from revit.async.

KennanChan commented on May 21, 2024

How did you implement your viewmodel? Especially in the "Information" property

from revit.async.

grizoood commented on May 21, 2024

With your example I get this exception at this line:

FamilyInstance instance = document.Create.NewFamilyInstance(new XYZ(0, 0, 0), symbol, StructuralType.NonStructural);

from revit.async.

KennanChan commented on May 21, 2024

try
{
  RevitTask.RunAsync(async (app) =>
  {
    int count = 20;

    var document = app.ActiveUIDocument.Document;
    Transaction transaction = new Transaction(document);
    transaction.Start("Insert");

    for (int i = 0; i < count; i++)
    {
      string family_2d = "Family";
      string symbol_2d = "Symbol";

      await RevitTask.RunAsync(
          app =>
          {
            Informations = $"Insert {i + 1}/{count}";
            var document = app.ActiveUIDocument.Document;
            var symbol = document.FindSymbol(family_2d, symbol_2d);
            FamilyInstance instance = document.Create.NewFamilyInstance(new XYZ(0, 0, 0), symbol, StructuralType.NonStructural);
          });

      await Task.Delay(1000);
    }

    transaction.Commit();
    transaction.Dispose();

    Informations = "Finished";
  });
}
catch (Exception ex)
{
}

Sorry, I don't have access to Revit at the moment. Please try entering the code again.

from revit.async.

grizoood commented on May 21, 2024

It doesn't change anything, same exception

try
{
    RevitTask.RunAsync(async (app) =>
    {
        int count = 20;

        var document = app.ActiveUIDocument.Document;
        Transaction transaction = new Transaction(document);
        transaction.Start("Insert");

        for (int i = 0; i < count; i++)
        {
            string family_2d = "Family";
            string symbol_2d = "Symbol";

            await RevitTask.RunAsync(
                app2 =>
                {
                    Informations = $"Insert {i + 1}/{count}";
                    var document2 = app2.ActiveUIDocument.Document;
                    var symbol = document2.FindSymbol(family_2d, symbol_2d);
                    FamilyInstance instance = document2.Create.NewFamilyInstance(new XYZ(0, 0, 0), symbol, StructuralType.NonStructural);
                });

            await Task.Delay(1000);
        }

        transaction.Commit();
        transaction.Dispose();

        Informations = "Finished";
    });
}
catch (Exception ex)
{
}

from revit.async.

KennanChan commented on May 21, 2024

I haven't used Revit in years. It seems that the beginning and committing of a transaction cannot be separated in different Revit contexts.

from revit.async.

grizoood commented on May 21, 2024

After this is only a part of code in fact I encounter another problem, when I execute my command my Information property is not updated in my interface, I only see the last message of the loop

from revit.async.

KennanChan commented on May 21, 2024

try
{
  int count = 20;

  for (int i = 0; i < count; i++)
  {
    string family_2d = "Family";
    string symbol_2d = "Symbol";
    
    // update information right before you enter an external event handler
    Informations = $"Insert {i + 1}/{count}";

    await RevitTask.RunAsync(
        app =>
        {

          var document = app.ActiveUIDocument.Document;

          using (Transaction transaction = new Transaction(document))
          {
            transaction.Start("Insert");

            var symbol = document.FindSymbol(family_2d, symbol_2d);

            FamilyInstance instance = document.Create.NewFamilyInstance(new XYZ(0, 0, 0), symbol, StructuralType.NonStructural);

            transaction.Commit();
          }
        });

    await Task.Delay(1000);
  }

  Informations = "Finished";
}
catch (Exception ex)
{
}

Slight changes to the working code.

from revit.async.

KennanChan commented on May 21, 2024

Is the issue still ongoing?

from revit.async.

grizoood commented on May 21, 2024

Yes but I close the issue

from revit.async.

Task dalay about revit.async HOT 21 CLOSED

Comments (21)

Related Issues (13)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent