VCR.py needs to be multipart-boundary agnostic about vcrpy HOT 8 CLOSED

And when running with wifi connected, I'm almost certain that both times the request was still made to the servers!

from vcrpy.

The integration test here fails when run without a wifi connection.

from vcrpy.

Note also that the integration test for testing POST requests is for some reason using redirect.yaml. I suspect this is a copy-and-paste error!

# In https://github.com/kevin1024/vcrpy/blob/master/tests/integration/test_requests.py...
def test_post(tmpdir, scheme):
    '''Ensure that we can post and cache the results'''
    data = {'key1': 'value1', 'key2': 'value2'}
    url = scheme + '://httpbin.org/post'
    with vcr.use_cassette(str(tmpdir.join('redirect.yaml'))) as cass:
    ...

from vcrpy.

I run this test the first time with my wifi connected and a second time with my wifi disconnected.

I'm unable to reproduce this problem. I ran your sample code once with the wifi on, and it produced the yaml file, and the second time with wifi off, and the test still passed.

Was fixtures/foobar.yaml created when you ran the test the first time?

Note also that the integration test for testing POST requests is for some reason using redirect.yaml.

Yeah, it's a copy/paste error, though it doesn't actually matter since those files are in a tmpdir specifically created just for that one test run. I'll fix that though, thanks for the heads-up.

The integration test here fails when run without a wifi connection.

Yes, the VCR test suite requires an internet connection (except for the unit tests, which don't make network requests). I decided to do this so I can test the creation of cassettes and to ensure that the connection correctly passes through to httplib if there is no cassette (too bad I can't use VCR to test VCR!)

from vcrpy.

Hey @kevin1024, thanks for responding promptly.

Apologies! The code I posted really doesn't produce the problem. I found a more clear way to reproduce the problem and updated the issue description:

        # This test SUCCEEDS
        def test_vcr_works_with_requests():
            with vcr.use_cassette('fixtures/test_vcr/foobar.yaml'):
                r = requests.post("http://requestb.in/179gbs61")

        # This test FAILS
        def test_vcr_works_with_requests_with_file_upload():
            with vcr.use_cassette('fixtures/test_vcr/foobar-file-upload.yaml'):
                with open (os.path.abspath('lolcat.jpg')) as f:
                    r = requests.post("http://requestb.in/179gbs61", files={'photo':f})

Yes, the VCR test suite requires an internet connection

Well I hope VCR tests in general do not require it — although we're always connected nowadays it's a matter of principle that tests should pass without it!

from vcrpy.

So I'm doing some detective work around this because I really want to get this working.

The relevant part that discriminates the two requests.post calls is:
https://github.com/kennethreitz/requests/blob/master/requests/models.py#L404

I'm no expert, but @kevin1024 you may be able to spot why VCR might be tripping up here.

from vcrpy.

Okay, with some Python debugging I found that this really is a simple case of the vcr.Request not being looked up in the requests OrderedDict correctly. Though the cassette strictly speaking contains the request, when performing the lookup the hashes mustn't have matched for some reason. I'll look into this further.

from vcrpy.

Closing since #29 and #30 address this same issue.

from vcrpy.