compat.collections getting loaded in Python 3 in some cases about vcrpy HOT 5 CLOSED

Hmm, what version of python3 are you using?

compat.counter should only load if collections.counter (part of the stdlib) doesnt' exist:

collections.counter was added in python 3.1.

Do you have any code that reproduces the issue?

from vcrpy.

@kevin1024 all work is here: pyvmomi/python3

The patches where I start working in python 3 are python3/log -> above this commit: .travis.yml with python3

The travis CI output is here: https://travis-ci.org/hartsock/pyvmomi/jobs/30786205

I can dev locally (installing developer versions of everything on python 3.4) applying the patch produces a different error. But I admit I'm not sure what's happening. Is it vcrpy or something else? The print thing was definitely inside vcrpy.

Edit:
Initial error I'm showing in the issue comment:

Running setup.py install for vcrpy
      File "/Users/hartsocks/.venv/pyvmomi-tools-py3/lib/python3.4/site-packages/vcr/compat/counter.py", line 192
        print doctest.testmod()
                    ^
    SyntaxError: invalid syntax

Is from my local environment ... attempting to reproduce the Travis CI error on python 3.4 so I can determine what failed. The error occurs on install of vcrpy.

from vcrpy.

A seemingly similar problem: guessit-io/guessit#71

from vcrpy.

I don't think the issue is with vcr.py, the setup.py test discovery seems to be failling. I hacked on it for a couple minutes and it seems to be running OK for me. I just sent a pull request, the tests are at least running on my local machine: hartsock/pyvmomi#2

A few things though, if it were my project, I would want to use a real test runner instead of using setup.py test. I recommend pytest + tox, a very powerful combination.

Here is a great blog post on python packaging, check out the section on running tests:

http://blog.ionelmc.ro/2014/05/25/python-packaging/#running-the-tests

from vcrpy.

Thanks for your help. I was able to figure out the issue on my end.

from vcrpy.