Giter VIP home page Giter VIP logo

Comments (8)

lucasnetau avatar lucasnetau commented on July 30, 2024

Hi @giannicolac , thank you for your report. I can reproduce the form-control class bring dropped, will investigate why.

row and col I cannot reproduce being dropped, they are recalculated when moving to a new row

from formbuilder.

giannicolac avatar giannicolac commented on July 30, 2024

The loss of col and row doesn't seem to happen in the DOM, but when getting the data, such classes are gone in my case, even if they are in the DOM elements and the "class" in the panel has them.

from formbuilder.

lucasnetau avatar lucasnetau commented on July 30, 2024

Please test out #1579, I've rewritten the syncFieldWithNewRow function which was corrupting the className string when dropped.

from formbuilder.

giannicolac avatar giannicolac commented on July 30, 2024

I replaced my form-builder.js file in src/js with the one you changed, but it doesnt seem to have changed anything about the behavior. The form-control classes disappear, and row and col are not in the data.

from formbuilder.

lucasnetau avatar lucasnetau commented on July 30, 2024

Hi @giannicolac did you ensure to rebuild after applying the patch? I've done additional refactoring this morning and also added Jest test cases plus manual testing. Classes are no longer being mangled

from formbuilder.

lucasnetau avatar lucasnetau commented on July 30, 2024

Please try this patched version form-builder.min.js.gz

from formbuilder.

giannicolac avatar giannicolac commented on July 30, 2024

This made it work, thank you.

from formbuilder.

github-actions avatar github-actions commented on July 30, 2024

🎉 This issue has been resolved in version 3.19.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

from formbuilder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.