Giter VIP home page Giter VIP logo

Comments (3)

kevinpapst avatar kevinpapst commented on August 25, 2024

Ok, quick look shows the the {# TODO test me #} above the macro.
I am not using this macro anywhere and have no use-case for it.
And the Demo app is not yet build, so I haven't even tried it... again: sorry 🤷

Can you fix the macro? I find it easiest if you have a real world use-case for it.

from tablerbundle.

cavasinf avatar cavasinf commented on August 25, 2024

There is no button in ContextHelper used by tabler_bundle.button.

How do you want to handle all default aspect (button and others) in the Bundle ?

  • Raw values
  • Do we let the dev to change default config via the tabler.yml
tabler:
    options:
        dark_mode: false
        [...]

    default:
        button:
            size: md
            type: primary

        button_link:
            size: sm
            type: link

        [...]

from tablerbundle.

kevinpapst avatar kevinpapst commented on August 25, 2024

I don't think we need configurable default values. We can document that users should wrap the functions.
I do it like this, so I can always change the values independently from the bundle:

{% macro action_button(icon, values, type) %}
    {% import '@theme/components/button.html.twig' as macro %}
    {{ macro.button(icon, values, type) }}
{% endmacro %}

The other error is fixed and I added examples how to use the embed to the demo app.

from tablerbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.