Comments (7)
TBH, I don't understand what is the point of that.
@kevinpapst What do you think about that ?
from tablerbundle.
Hm, just had a quick look. The ID is not used for anything and I guess it is better if it does not exist on the page (prevent page jumping?).
So probably it is just a dumb placeholder and we could change it to href="#"
.
But it works for me, so I don't really care and would prefer not wasting any more time thinking about it 😁
But if you have an issue with it: can you please elaborate what you see as problem here?
from tablerbundle.
When using SWUP JS,
it triggers me a warning every time I open a menu item:
from tablerbundle.
I don't know SWUP JS, but if you find a way to fix the issue, please go ahead and sent a PR.
Isn't there some way to tell swup to ignore certain html elements?
from tablerbundle.
SWUP JS is looking for any HTML URI fragment (#).
I think it's better that the template allow us to put anything, instead of trying to override SWUP default behavior.
I've asked tabler/tabler#993 what is the purpose of that.
from tablerbundle.
I saw that nobody answered in the tabler repo, which unfortunately happens often there...
Why not simply changing it, if it causes issue?
from tablerbundle.
Yeah, sadly non one answered 😞.
I've removed that part on the #3 PR.
from tablerbundle.
Related Issues (20)
- Component - Carousel HOT 3
- Include a Screenshot from the demo project in the project readme HOT 1
- Menu item allows `null` route name but not when rendered HOT 1
- Card embed block names HOT 5
- Update Tabler to beta15 HOT 2
- [Twig] File Name convention HOT 1
- [Button] `btn-sm` and `icon` class
- [Menu] Set it more customizable? HOT 5
- [Trans] Auto trans on devs content should not be a thing HOT 10
- [Twig] Rename all `url` params to `href`
- Support Symfony 7 in TablerBundle HOT 2
- release 1.0 HOT 2
- support ux components HOT 6
- Flash messages not displayed after redirectToRoute() HOT 9
- [Docs] Dynamic theme options (like dark mode) HOT 3
- Update to beta 20 HOT 1
- [Feature] Image Check Checkbox/Radio Inputs HOT 3
- [Icon] Bye bye `tabler_icon` ➡️ Welcome Symfony UX Icon 🎉 HOT 9
- [Help needed] How do I use this bundle with Symfony's new AssetMapper? HOT 1
- addChild() return void, docs show fluent setter
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tablerbundle.