Giter VIP home page Giter VIP logo

Comments (7)

cavasinf avatar cavasinf commented on August 25, 2024

TBH, I don't understand what is the point of that.

@kevinpapst What do you think about that ?

from tablerbundle.

kevinpapst avatar kevinpapst commented on August 25, 2024

Hm, just had a quick look. The ID is not used for anything and I guess it is better if it does not exist on the page (prevent page jumping?).
So probably it is just a dumb placeholder and we could change it to href="#".
But it works for me, so I don't really care and would prefer not wasting any more time thinking about it 😁

But if you have an issue with it: can you please elaborate what you see as problem here?

from tablerbundle.

cavasinf avatar cavasinf commented on August 25, 2024

When using SWUP JS,
it triggers me a warning every time I open a menu item:
image

from tablerbundle.

kevinpapst avatar kevinpapst commented on August 25, 2024

I don't know SWUP JS, but if you find a way to fix the issue, please go ahead and sent a PR.
Isn't there some way to tell swup to ignore certain html elements?

from tablerbundle.

cavasinf avatar cavasinf commented on August 25, 2024

SWUP JS is looking for any HTML URI fragment (#).

I think it's better that the template allow us to put anything, instead of trying to override SWUP default behavior.

I've asked tabler/tabler#993 what is the purpose of that.

from tablerbundle.

kevinpapst avatar kevinpapst commented on August 25, 2024

I saw that nobody answered in the tabler repo, which unfortunately happens often there...

Why not simply changing it, if it causes issue?

from tablerbundle.

cavasinf avatar cavasinf commented on August 25, 2024

Yeah, sadly non one answered 😞.
I've removed that part on the #3 PR.

from tablerbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.