Fix: pmx.notify should be able to send other data type than Error only about pm2-io-apm HOT 12 CLOSED

https://github.com/keymetrics/pmx-2/blob/master/src/features/notify.ts#L37

from pm2-io-apm.

Why closing it?

from pm2-io-apm.

Misunderstood the title, currently everything expect that the notify send an error. Both frontend and backend, so i think we can just force it to be an error.
If people want to send additional metadata, they need to attach it to the error object like we do with the express middleware for example.

from pm2-io-apm.

It really depends on what notify mean !
Does it mean :

• notify me if an error occurred ?
• or just notify me when an event is emitted ?

We can have a notify method and a notifyError method if we want to do both.

from pm2-io-apm.

or just notify me when an event is emitted

We have pmx.emit event specially for this, and you can setup alert on it.

from pm2-io-apm.

We will need to rename this methods anyway.

Example for custom error handling on newrelic:
newrelic.noticeError(e, { message: "record custom event failed" });

from pm2-io-apm.

Of course we can change the high level API but for the event process:exception sent to the backend, the data sended should be in the form of an error, in the present or the future.
We can maybe add different event with like process:error ?

from pm2-io-apm.

from pm2-io-apm.

I think we just should reserve the event process:exception for runtime error that can't be avoided (= crash), and process:error that are handled by the user

from pm2-io-apm.

Currently, send method in transport class can send any kind of object.

from pm2-io-apm.

Also note how pmx try to adapt the object sended via pmx.notify : https://github.com/keymetrics/pmx-2/blob/master/src/features/notify.ts#L134

from pm2-io-apm.

pmx.notifyError(new Error(msg), { context })

from pm2-io-apm.