biquad_filter processing about kfr HOT 6 CLOSED

@netlcod
Thank you for reporting this issue. The adapt function is required here for multidimensional arrays (tensors), so it isn't an option to remove it. But the adapt function assumes a valid index passed to it which isn't a case for the stop index (past-the-end index). This also affected all expressions that relied on start and stop arguments in their begin_pass and end_pass functions.
I've pushed a fix, could you try to pull dev branch and rerun your tests?

from kfr.

In the line bqfilter->apply(batch); filtering gives wrong result.
But if you replace it with bqfilter->apply(batch.data(), samples+1), the result becomes adequate.
Result with samples+1:

What i do wring? Or it is library bug?

from kfr.

It seems to me that the library is the problem. When get_element gets a invalid index, it returns 0. So for the last sample it returns 0 instead of a valid value.

from kfr.

In the file kfr/base/expression.cpp at line 726
begin_pass(in, inshape.adapt(start), inshape.adapt(stop));
the array size is reduced. If you replace it to the line
begin_pass(in, start, stop);
the filters work normally.

So I have a question, I need to replace
begin_pass(in, inshape.adapt(start), inshape.adapt(stop));
to the line
begin_pass(in, start, stop);
or i need replace in file shape.hpp in line 283
return other.template trim<dims>()->min(**this - 1);
to the
return other.template trim<dims>()->min(**this);

from kfr.

@dancazarin ?

from kfr.

@dancazarin yes, it works, thanks!

from kfr.