Use CRC32 instead of counter to de-dup styles about aphrodite HOT 6 CLOSED

Hmm, I guess JSON.stringify isn't guaranteed to produce the same results on the server and client, so this might be a non-starter. We could code our own stable stringify function for our styles, perhaps?

from aphrodite.

It isn't?

from aphrodite.

@spicyj From (minimal) searching, I couldn't find anything providing a guarantee about character-for-character output matching for JSON.stringify between browsers, but maybe it does. If it does, great!

from aphrodite.

The ES6 spec (and I assume, ES5 too) specifies the exact behavior, like almost everything in JS.

from aphrodite.

This sounds excellent! This would also have the benefit of deduplicating styles that occur over different files but look the same (which I'm sure we're going to end up having all over the place).

It'd be nice to also think about how we want to do minification. It'd be nice if we could map from the really long concatenated names to something much shorter. That might require an extra step for rehydration (like passing a map of long name -> short name form the server to the client version of aphrodite).

from aphrodite.

Fixed by f45f87d

from aphrodite.