Comments (5)
I believe the STD vector collecton automatically frees the memory after
execution. Is this not correct? Try running valgrind to look for memory leaks,
to which I believe there are none at the moment...
Original comment by [email protected]
on 14 Dec 2011 at 3:01
from poly2tri.
EDIT: Google is your friend; stackoverflow.com answers the same exact question.
STD::vector does destruct its elements when it goes out of scope. The problem
here is that your elements are pointers to data type Point, not Point structs
themselves. If you instead did something like this:
vector<A> vec;
vec.push_back(A(1));
vec.push_back(A(2));
...then things would work as you expect.
Original comment by [email protected]
on 14 Dec 2011 at 3:13
- Changed state: Invalid
from poly2tri.
a vector<Point> would indeed free the Point but a vector<Point *> (which is the
CDT constructor argument) will not. It's just that I can't tell whether the
library is meant to free it for you.
I have been freeing my lists when I finish with them and I am not getting any
double-free errors.
Not a big deal, really.
Thanks for your work on this algorithm. It's quite fast :)
Original comment by [email protected]
on 14 Dec 2011 at 9:31
from poly2tri.
I added code to the testbed example to free the points. I believe this should
be the user's responsibility, not poly2tri per se.
Thanks for pointing this out; improves the example code.
Original comment by [email protected]
on 4 Feb 2012 at 9:04
- Changed state: Fixed
from poly2tri.
Yup I'm glad you took a look at this a second time. It certainly is the user's
responsibility to free the points, and the testbed is meant to demonstrate what
the user is supposed to do.
Thanks
Original comment by [email protected]
on 4 Feb 2012 at 9:19
from poly2tri.
Related Issues (20)
- Java source unbuildable in 1.7+
- Build failed when compliling with -we4715
- Java findbugs - nullcheck of value previously dereferenced HOT 1
- [java] Tessellation with hole error HOT 4
- Polygon with hole HOT 10
- [java] Missing triangle in non-constrained delaunay HOT 3
- Problem building library
- the EPSILON value is not exported in the python/cython version HOT 1
- Compilation fails with MSVC
- CMake build script
- Inconsistent behavior with holes that share a point HOT 17
- add typedef for "double"
- add typedef for std::vector<Point*>, std::vector<Triangle*> and other containers
- Triangulate crashes in sweep.cc:703 HOT 3
- java version compile error HOT 3
- Polygon.getHoles() missing HOT 5
- poly2tri crashes on a very simple geometry HOT 1
- crash with attached polygon HOT 2
- Crash when triangulating a polygon HOT 1
- crash with square polygon HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from poly2tri.