mp3fs segfault when sharing files via samba about mp3fs HOT 8 CLOSED

The best way to approach this is to come up with a test case. What is unique about the samba access pattern? The first thing that jumps out at me are the failed attempts to LOOKUP /mp3fs. Is samba doing that? Or is another process doing so? Maybe this is a bug that shows up with two processes accessing the fuse filesystem.

If you can think of another process that is doing the /mp3fs lookups, then stop that process and see if the samba access starts working. That would narrow down what is going on.

from mp3fs.

I believe this is a problem with the Vampire Weekend/Vampire Weekend/03 A-Punk.flac file. Notice all of the errors from FLAC right before the segfault. Is there a way you can share that file with me? It seems I'm not properly handling errors.

from mp3fs.

Hi, I have the same issue and added the file. I have this problem a lot. I was pointed here by an answer to my question here.

On my clients I use Lubuntu 18.04 and 18.10. I did however successfully copy this file (and others) the last time with Lubuntu 16.04. Not sure if this makes sense.

I was not able to compress my flac, so I made three files with ZIP that had the names

file.zip.001
file.zip.002
file.zip.003

I had to strip the 000-part to be able to upload it as a supported file format (ZIP). Please remove the 000-part from the front and put it at the end, as seen above.

file001.zip
file002.zip
file003.zip

from mp3fs.

I'm trying to reproduce this, and I'm having trouble, even with the file you provided. Can you please try the following:

1. Instead of mounting mp3fs from /etc/fstab, please run catchsegv mp3fs -d <args> where you replace <args> with appropriate arguments.
2. Please reproduce the segfault and paste the last 100 lines or so here. There will (hopefully) be a backtrace in the output that I can use to see what's happening.

Thanks!

from mp3fs.

Aha! I found the issue, it has to do with concurrent reads from the same file, and mp3fs not being properly thread-safe. I'll look into the issue some more.

from mp3fs.

Do you still need something? I think it still works well with Lubuntu 16.04.05 LTS on an ASUS F205 laptop (Intel Atom). I have issues on my Shuttle Barebone PC with a powerfull CPU. But even there I was able to use it withou problems under Lubuntu 16.04 or 16.10. The change in behaviour came with my upgrade to 18.04 I guess. Maybe this is related to the way CIFS works now.

from mp3fs.

I don't need anything else, I'm able to reproduce the issue, thanks. I just need to implement a fix now.

from mp3fs.

This should now be resolved with the latest commit pushed to master.

from mp3fs.