Comments (2)
Thanks for finding this and the great writeup @lisyarus! I think @bsdorra is going to take a swing at a fix that includes the updates to other extensions mentioned by @proog128. We'd love to hear feedback on the fix once the PR goes online.
from gltf.
This is indeed a bug in the pseudocode which has been there for a very long time, thanks for your detailed report and derivations. Your proposal looks good, it's also more readable than the old version. However, it will change the look of the material, which might have to be discussed @emackey. This particular code snippet in the "new" Appendix B is identical to the one in the "old" Appendix B (before the rewrite), I copied this bug without noticing. Because it's only in the non-normative part, I suppose the change is fine. Might be a good idea to also check the sample viewer, it might also be affected.
I'd be happy to make a pull request myself (in case I'm not misunderstanding things, of course!).
Since you change the naming of some terms, it's required to adapt the extension too. I think KHR_materials_specular, _ior, _clearcoat, and maybe also _iridescence have to be updated.
from gltf.
Related Issues (20)
- Ad some video file capability HOT 3
- Typo in Smith joint shadowing-masking function HOT 2
- Question about Accessor's Min-Max bounds with normalized data. HOT 1
- Undefined behaviour in KHR_materials_volume HOT 10
- 3.7.3.3 how many non-zero weights per vertex HOT 1
- 3.7.2.1 COLOR_0 is special? HOT 1
- KHR_materials_clearcoat Fresnel should not influence material emission HOT 4
- Request for MANYFOLD vendor prefix HOT 1
- Visibility function glyph not rendered in PDF HOT 3
- EXT_mesh_gpu_instancing: used vs required?
- Clarify anisotropy usage HOT 9
- Bone Animation, not using Skinning HOT 4
- Tool to remove skin bind matrices from glTF file and resave? HOT 8
- In KHR_texture_transform extension, uv should be "fract" before transforming? HOT 7
- Add TRACE vendor prefix
- Animations: Channel samplers sync HOT 4
- Poor LaTeX in Appendix C (Interpolation)
- Inconsistent object field naming in Material for generic properties HOT 7
- 形态键和动画不同步 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gltf.