Comments (3)
Just a note: This is best left until after this repo is made public because Travis-CI only works with public repos.
(Building the repo in CI would be a nice thing to have, too)
from moltenvk.
To proceed on this:
-
Need to decide on what version of clang-format to use. Yes, this matters (slightly) because different major versions of clang-format format differently. macOS 10.12 seems to have version 6.0.0. You would want to document this in a CONTRIBUTING.md. We also would want to match the version running on the CI machine. While it may be possible to install a specific version on the CI machine, it may be good to know what version is already there. (I tried to submit a Travis job from my fork to query this, but Travis seems to be having trouble displaying logs at the moment.)
-
Need to decide on clang-format parameters and put them in a
.clang-format
file at the top of the repo. This is where you get to pick a basic style (e.g., LLVM or Google) and make tweaks such as line length and tab size. You can look at other repos for ideas and/or try to match any existing style in the code base. Check this file into the repo. -
Get the current repo formatted. You would do this by running clang-format (using
-style=file
) on all the sources in the repo and commit. It probably would have been better to do this and the preceding steps before going public, but there's little that can be done about that. This does introduce a "format only" commit that will show up often in "git blame" type searches in the code base, but that would have to be tolerated. -
Add the CI plumbing to check that incoming PRs are formatted. (The point of this issue). As an example, this was added with KhronosGroup/Vulkan-LoaderAndValidationLayers@b11b529. I'd be happy to do this part of it once the
ableabove steps are done.
from moltenvk.
Travis got healthy again. clang-format
is not installed by default, but is easily installed with brew
, and it is version 6.0.0.
from moltenvk.
Related Issues (20)
- Possible regression in Khronos buffer_device_address sample in MoltenVK 1.2.8 HOT 5
- GPU address fault error when using descriptor indexing + variable descriptor count HOT 2
- Unnecessary 'Metal does not support disabling primitive restart' warnings HOT 8
- Support VK_EXT_rasterization_order_attachment_access
- EXC_BAD_ACCESS from mvkUpdateDescriptorSets on macOS HOT 13
- Latest MoltenVK instable on iOS and macOS HOT 7
- Uncaught selector, -[CAMetalDrawable addPresentedHandler:] (first introduced 1.2.6) HOT 20
- Possible regression in timeline semaphores on iOS in MoltenVK 1.2.10 HOT 3
- Was Vulkan SDK 1.3.290 released with MoltenVK 1.2.9? HOT 2
- Texture sharing between OpenGL and Vulkan on macOS
- Library not loaded: CoreSimulator when building MoltenVK in CI HOT 2
- Vulkan checkinfo broken in MoltenVK MacOS M1 HOT 5
- vkQueuePresentKHR often crashes HOT 2
- Bindless textures not always work with 1.2.10 on mac HOT 1
- Support more 32-bit floating-point pixel format caps on iOS HOT 1
- Enable blending cap for RGB9E5Float HOT 1
- `vkCmdSetScissor` behavior violates vulkan spec
- Swapchain images are incorrectly displayed in borderless fullscreen when using particular VkFormats
- vkQueueSubmit is leaking 13 GB of memory at every call when using an SSBO HOT 2
- DeviceAddressBuffer (encodeGPUAddressableBuffers) resource usage bug
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moltenvk.